feat!: Add network_profile setting to network, update network resource provider #584
+31
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bharathkkb
changed the title
imrannayer
reviewed
Dec 10, 2024
|
@cdunbar13 can u plz add update following doc Also fix lint issues. Follow this doc |
|
/gcbrun |
|
/gcbrun |
imrannayer
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
network_profilesetting to thegoogle_compute_networkresource and to the top level module. This change is necessary to enable the RDMA profiles, required for the new GPU machine types on GCP.This is currently untested and will be updated once the
google-betaprovider with these changes has been released (expected 11/25/24).