Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: add instances_details sensitive output #308

Merged
merged 2 commits into from
Sep 13, 2023
Merged

fix!: add instances_details sensitive output #308

merged 2 commits into from
Sep 13, 2023

Conversation

matusso
Copy link
Contributor

@matusso matusso commented May 10, 2023

Added sensitive = true for instances_details to avoid following error.
Error: Output refers to sensitive values

│ on outputs.tf line 22:
│ 22: output "instances_details" {

│ To reduce the risk of accidentally exporting sensitive data that was
│ intended to be only internal, Terraform requires that any root module
│ output containing sensitive data be explicitly marked as sensitive, to
│ confirm your intent.

│ If you do intend to export this data, annotate the output value as
│ sensitive by adding the following argument:
│ sensitive = true

@matusso matusso requested a review from a team as a code owner May 10, 2023 13:19
@google-cla
Copy link

google-cla bot commented May 10, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@dennislapchenko
Copy link

Any plans to merge this soon?

@apeabody
Copy link
Contributor

Any plans to merge this soon?

Hi @matusso - Please visit https://cla.developers.google.com so we can review this PR. Thanks!

@matusso
Copy link
Contributor Author

matusso commented Jun 13, 2023

@apeabody done

@github-actions
Copy link

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Aug 13, 2023
@apeabody apeabody removed the Stale label Aug 14, 2023
@apeabody apeabody changed the title Update outputs.tf fix: instances_details output Aug 14, 2023
@apeabody
Copy link
Contributor

/gcbrun

Added sensitive = true for instances_details
@matusso
Copy link
Contributor Author

matusso commented Sep 13, 2023

could it be possible to finally close it? come on, I know u r big company, processes & stuff, but you should be able to close one-line merge request

@apeabody
Copy link
Contributor

/gcbrun

@apeabody apeabody changed the title fix: instances_details output fix!: instances_details sensitive output Sep 13, 2023
@apeabody apeabody changed the title fix!: instances_details sensitive output fix!: add instances_details sensitive output Sep 13, 2023
Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @matusso!

@apeabody apeabody merged commit 85fd51e into terraform-google-modules:master Sep 13, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants