feat: support setting nic_type of primary network interface #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpdownes
force-pushed
the
support_nic_type
branch
from
4fbdcb6
to
e1478ec
Compare
tpdownes
force-pushed
the
support_nic_type
branch
from
e1478ec
to
4be80d3
Compare
tpdownes
force-pushed
the
support_nic_type
branch
from
4be80d3
to
6d3089c
Compare
bharathkkb
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to specify the NIC type of the primary network interface for instance templates. This field is important VM families and operating systems that support GVNIC and get increased network performance. It defaults to null, the current behavior (unspecified), so this is not a change that requires user action.
var.additional_networkssupports this field, but the primary interface does not.I can eventually see a breaking change where
var.additional_networksbecomesvar.networks(or var.network_interfaces) and the primary network interface is inferred from the 1st element in the list. This would eliminate functionality gaps between the primary interface and secondary interfaces.