internal/network/acl: Add network ACL resource tests

Signed-off-by: Fabian Mettler <[email protected]> (cherry picked from commit f36ed672f67469718348673cd2551597c7bfd926) Signed-off-by: Din Music <[email protected]>
terraform-lxd · Jul 8, 2024 · e747c28 · e747c28
1 parent a413b63
commit e747c28
Showing 1 changed file with 237 additions and 0 deletions.
diff --git a/internal/network/resource_network_acl_test.go b/internal/network/resource_network_acl_test.go
@@ -0,0 +1,237 @@
+package network_test
+
+import (
+	"fmt"
+	"testing"
+
+	"github.com/hashicorp/terraform-plugin-testing/helper/resource"
+	"github.com/terraform-lxd/terraform-provider-lxd/internal/acctest"
+)
+
+func TestAccNetworkACL_basic(t *testing.T) {
+	aclName := acctest.GenerateName(2, "-")
+
+	resource.Test(t, resource.TestCase{
+		PreCheck:                 func() { acctest.PreCheck(t) },
+		ProtoV6ProviderFactories: acctest.ProtoV6ProviderFactories,
+		Steps: []resource.TestStep{
+			{
+				Config: testAccNetworkACL(aclName),
+				Check: resource.ComposeTestCheckFunc(
+					resource.TestCheckResourceAttr("lxd_network_acl.acl", "name", aclName),
+					resource.TestCheckResourceAttr("lxd_network_acl.acl", "description", "Network ACL"),
+				),
+			},
+		},
+	})
+}
+
+func TestAccNetworkACL_egress(t *testing.T) {
+	aclName := acctest.GenerateName(2, "-")
+
+	entry1 := map[string]string{
+		"action":           "allow",
+		"destination":      "1.1.1.1,1.0.0.1",
+		"destination_port": "53",
+		"protocol":         "udp",
+		"description":      "DNS to cloudflare public resolvers (UDP)",
+		"state":            "enabled",
+	}
+
+	entry2 := map[string]string{
+		"action":           "allow",
+		"destination":      "1.1.1.1,1.0.0.1",
+		"destination_port": "53",
+		"protocol":         "tcp",
+		"description":      "DNS to cloudflare public resolvers (TCP)",
+		"state":            "enabled",
+	}
+
+	resource.Test(t, resource.TestCase{
+		PreCheck:                 func() { acctest.PreCheck(t) },
+		ProtoV6ProviderFactories: acctest.ProtoV6ProviderFactories,
+		Steps: []resource.TestStep{
+			{
+				Config: testAccNetworkACL_withEgressRules(aclName),
+				Check: resource.ComposeTestCheckFunc(
+					resource.TestCheckResourceAttr("lxd_network_acl.acl", "name", aclName),
+					resource.TestCheckResourceAttr("lxd_network_acl.acl", "description", "Network ACL"),
+					resource.TestCheckTypeSetElemNestedAttrs("lxd_network_acl.acl", "egress.*", entry1),
+					resource.TestCheckTypeSetElemNestedAttrs("lxd_network_acl.acl", "egress.*", entry2),
+				),
+			},
+		},
+	})
+}
+
+func TestAccNetworkACL_ingress(t *testing.T) {
+	aclName := acctest.GenerateName(2, "-")
+
+	entry := map[string]string{
+		"action":           "allow",
+		"source":           "@external",
+		"destination_port": "22",
+		"protocol":         "tcp",
+		"description":      "Incoming SSH connections",
+		"state":            "logged",
+	}
+
+	resource.Test(t, resource.TestCase{
+		PreCheck:                 func() { acctest.PreCheck(t) },
+		ProtoV6ProviderFactories: acctest.ProtoV6ProviderFactories,
+		Steps: []resource.TestStep{
+			{
+				Config: testAccNetworkACL_withIngressRules(aclName),
+				Check: resource.ComposeTestCheckFunc(
+					resource.TestCheckResourceAttr("lxd_network_acl.acl", "name", aclName),
+					resource.TestCheckResourceAttr("lxd_network_acl.acl", "description", "Network ACL"),
+					resource.TestCheckTypeSetElemNestedAttrs("lxd_network_acl.acl", "ingress.*", entry),
+				),
+			},
+		},
+	})
+}
+
+func TestAccNetworkACL_egressAndIngress(t *testing.T) {
+	aclName := acctest.GenerateName(2, "-")
+
+	ingresEntry := map[string]string{
+		"action":           "allow",
+		"source":           "@external",
+		"destination_port": "22",
+		"protocol":         "tcp",
+		"description":      "Incoming SSH connections",
+		"state":            "logged",
+	}
+
+	egressEntry1 := map[string]string{
+		"action":           "allow",
+		"destination":      "1.1.1.1,1.0.0.1",
+		"destination_port": "53",
+		"protocol":         "udp",
+		"description":      "DNS to cloudflare public resolvers (UDP)",
+		"state":            "enabled",
+	}
+
+	egressEntry2 := map[string]string{
+		"action":           "allow",
+		"destination":      "1.1.1.1,1.0.0.1",
+		"destination_port": "53",
+		"protocol":         "tcp",
+		"description":      "DNS to cloudflare public resolvers (TCP)",
+		"state":            "enabled",
+	}
+
+	resource.Test(t, resource.TestCase{
+		PreCheck:                 func() { acctest.PreCheck(t) },
+		ProtoV6ProviderFactories: acctest.ProtoV6ProviderFactories,
+		Steps: []resource.TestStep{
+			{
+				Config: testAccNetworkACL_withTrafficRules(aclName),
+				Check: resource.ComposeTestCheckFunc(
+					resource.TestCheckResourceAttr("lxd_network_acl.acl", "name", aclName),
+					resource.TestCheckResourceAttr("lxd_network_acl.acl", "description", "Network ACL"),
+					resource.TestCheckTypeSetElemNestedAttrs("lxd_network_acl.acl", "egress.*", egressEntry1),
+					resource.TestCheckTypeSetElemNestedAttrs("lxd_network_acl.acl", "egress.*", egressEntry2),
+					resource.TestCheckTypeSetElemNestedAttrs("lxd_network_acl.acl", "ingress.*", ingresEntry),
+				),
+			},
+		},
+	})
+}
+
+func testAccNetworkACL(aclName string) string {
+	return fmt.Sprintf(`
+resource "lxd_network_acl" "acl" {
+  name        = "%s"
+  description = "Network ACL"
+}
+  `, aclName)
+}
+
+func testAccNetworkACL_withEgressRules(aclName string) string {
+	return fmt.Sprintf(`
+resource "lxd_network_acl" "acl" {
+  name        = "%s"
+  description = "Network ACL"
+
+  egress = [
+    {
+      description      = "DNS to cloudflare public resolvers (UDP)"
+      action           = "allow"
+      destination      = "1.1.1.1,1.0.0.1"
+      destination_port = "53"
+      protocol         = "udp"
+      state            = "enabled"
+    },
+    {
+      description      = "DNS to cloudflare public resolvers (TCP)"
+      action           = "allow"
+      destination      = "1.1.1.1,1.0.0.1"
+      destination_port = "53"
+      protocol         = "tcp"
+      state            = "enabled"
+    }
+  ]
+}
+  `, aclName)
+}
+
+func testAccNetworkACL_withIngressRules(aclName string) string {
+	return fmt.Sprintf(`
+resource "lxd_network_acl" "acl" {
+  name        = "%s"
+  description = "Network ACL"
+
+  ingress = [
+    {
+      description      = "Incoming SSH connections"
+      action           = "allow"
+      source           = "@external"
+      destination_port = "22"
+      protocol         = "tcp"
+      state            = "logged"
+    }
+  ]
+}
+  `, aclName)
+}
+
+func testAccNetworkACL_withTrafficRules(aclName string) string {
+	return fmt.Sprintf(`
+resource "lxd_network_acl" "acl" {
+  name        = "%[1]s"
+  description = "Network ACL"
+
+  egress = [
+    {
+      description      = "DNS to cloudflare public resolvers (UDP)"
+      action           = "allow"
+      destination      = "1.1.1.1,1.0.0.1"
+      destination_port = "53"
+      protocol         = "udp"
+      state            = "enabled"
+    },
+    {
+      description      = "DNS to cloudflare public resolvers (TCP)"
+      action           = "allow"
+      destination      = "1.1.1.1,1.0.0.1"
+      destination_port = "53"
+      protocol         = "tcp"
+      state            = "enabled"
+    }
+  ]
+
+  ingress = [
+    {
+      description      = "Incoming SSH connections"
+      action           = "allow"
+      source           = "@external"
+      destination_port = "22"
+      protocol         = "tcp"
+      state            = "logged"
+    }
+  ]
+}
+  `, aclName)
+}