Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop deprecated lxd_volume_container_attach resource #348

Merged

Conversation

simondeziel
Copy link
Member

This resource was deprecated in 2017 so it feels like a good time to drop it.

@simondeziel simondeziel force-pushed the drop-lxd_volume_container_attach branch 2 times, most recently from d7d4eee to ef20238 Compare September 7, 2023 18:58
@adamcstephens
Copy link
Collaborator

I think we'd want to cut a major release to remove a deprecated resource. (Though it has been quite a while) It looks like LTS 3.0 is no longer supported upstream, so maybe we can batch up a few breaking changes and release 2.0? It's probably too soon to drop the container resources, but if y'all think it should be included I'd be happy to discuss.

@MusicDin
Copy link
Member

MusicDin commented Sep 7, 2023

Is this deprecated in LXD 3.0.0? Otherwise we could wait until we drop support for this LXD version

@simondeziel
Copy link
Member Author

LXD 3.0 is the last release that does not support VMs.

@MusicDin
Copy link
Member

MusicDin commented Sep 7, 2023

Could we maybe drop support even for 3.0.0 in next major release? This would drastically simplify future work, as 4.0 was really a major release

@simondeziel
Copy link
Member Author

simondeziel commented Sep 7, 2023

In terms of breaking changes leading to terraform-provider-lxd 2.0, I'd like to drop:

@simondeziel
Copy link
Member Author

simondeziel commented Sep 7, 2023

To provide more context, LXD 3.0 was released with Ubuntu 18.04 so back in 2018. 18.04 went out of regular support in April 2023 and LXD 3.0 shortly after. Even if you still have some 18.04 kicking around, you can switch to the snap and migrate to LXD 4.0 easily. As such, I'm all for making 4.0 the minimum supported version.

@MusicDin
Copy link
Member

MusicDin commented Sep 7, 2023

If I understand correctly, this attach resource can no longer be used as it was no longer supported in 3.0.0? If so, we can safely merge this PR, as user already cannot use this provider with LXD lower then 3.0.0.

For next major release I would also like to finish configuration management, as currently it is broken wherever LXD uses configuration map (network and storage being most critical).

@simondeziel
Copy link
Member Author

simondeziel commented Sep 7, 2023

If I understand correctly, this attach resource can no longer be used as it was no longer supported in 3.0.0? If so, we can safely merge this PR, as user already cannot use this provider with LXD lower then 3.0.0.

No, the 2 are unrelated. The lxd_volume_container_attach resource is not needed as you can accomplish the same with an instance device referencing a lxd_volume.

For next major release I would also like to finish configuration management, as currently it is broken wherever LXD uses configuration map (network and storage being most critical).

Indeed, that'd be nice; I only providing a "legacy code to drop" wishlist ;)

@adamcstephens
Copy link
Collaborator

Are y'all interested in breaking out your wishlists into issues and linking to https://github.com/orgs/terraform-lxd/projects/1 ? We can also just use a tracking issue if preferred.

I'll be out of town the next couple days, but I'd love to work out what we want to clean up and track towards a new release. Please share any thoughts you have. :)

@MusicDin
Copy link
Member

@adamcstephens @simondeziel
I think that we can drop the container resource, migrate to terraform framework (from SDKv2), add fix for configuration inconsistencies, and make release 2.0?

If you both agree, I would kindly ask @simondeziel to rebase this PR and also drop all resources related to old container resource.

This resource was deprecated in 2017

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@MusicDin
Copy link
Member

I'm currently migrating to terraform-framework and am wondering whether we should separate resource into different directories (for readability)?

@adamcstephens
Copy link
Collaborator

I'm currently migrating to terraform-framework and am wondering whether we should separate resource into different directories (for readability)?

That works for me. I have no attachment to the current flat structure. Is there a recommendation either way with terraform-framework?

@simondeziel
Copy link
Member Author

@adamcstephens I'll leave it up to you to review/merge the few PRs that are on the provider 2.0 release roadmap.

@adamcstephens adamcstephens merged commit fd2c188 into terraform-lxd:main Nov 15, 2023
4 checks passed
@adamcstephens adamcstephens changed the title Drop lxd_volume_container_attach resource Drop deprecated lxd_volume_container_attach resource Nov 15, 2023
@simondeziel simondeziel deleted the drop-lxd_volume_container_attach branch November 15, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants