-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop deprecated lxd_volume_container_attach resource #348
Drop deprecated lxd_volume_container_attach resource #348
Conversation
d7d4eee
to
ef20238
Compare
I think we'd want to cut a major release to remove a deprecated resource. (Though it has been quite a while) It looks like LTS 3.0 is no longer supported upstream, so maybe we can batch up a few breaking changes and release 2.0? It's probably too soon to drop the |
Is this deprecated in LXD |
LXD 3.0 is the last release that does not support VMs. |
Could we maybe drop support even for |
In terms of breaking changes leading to
|
To provide more context, LXD 3.0 was released with Ubuntu 18.04 so back in 2018. 18.04 went out of regular support in April 2023 and LXD 3.0 shortly after. Even if you still have some 18.04 kicking around, you can switch to the snap and migrate to LXD 4.0 easily. As such, I'm all for making 4.0 the minimum supported version. |
If I understand correctly, this For next major release I would also like to finish configuration management, as currently it is broken wherever LXD uses configuration map (network and storage being most critical). |
No, the 2 are unrelated. The
Indeed, that'd be nice; I only providing a "legacy code to drop" wishlist ;) |
Are y'all interested in breaking out your wishlists into issues and linking to https://github.com/orgs/terraform-lxd/projects/1 ? We can also just use a tracking issue if preferred. I'll be out of town the next couple days, but I'd love to work out what we want to clean up and track towards a new release. Please share any thoughts you have. :) |
@adamcstephens @simondeziel If you both agree, I would kindly ask @simondeziel to rebase this PR and also drop all resources related to old |
This resource was deprecated in 2017 Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
ef20238
to
1da89ac
Compare
I'm currently migrating to terraform-framework and am wondering whether we should separate resource into different directories (for readability)? |
That works for me. I have no attachment to the current flat structure. Is there a recommendation either way with terraform-framework? |
@adamcstephens I'll leave it up to you to review/merge the few PRs that are on the |
This resource was deprecated in 2017 so it feels like a good time to drop it.