Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ArcGIS Rest Service Layer UI #715

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from
Draft

Add ArcGIS Rest Service Layer UI #715

wants to merge 16 commits into from

Conversation

JakobMiksch
Copy link
Contributor

@JakobMiksch JakobMiksch commented Jan 4, 2023 •
edited
Loading

@JakobMiksch JakobMiksch mentioned this pull request Jan 4, 2023
Draft
5 tasks
@JakobMiksch JakobMiksch changed the title Arcgis rest service layers Add ArcGIS Rest Service Layer UI Jan 4, 2023
@fergaldoyle
Copy link
Contributor

fergaldoyle commented Feb 7, 2023 •
edited
Loading

@JakobMiksch to fix tests failing in this pull request, the dependant changes in @geoext/geoext will have to be published to NPM, then @geoext/geoext version number will need to be updated in package.json.

Alternatively, we could temporarily update package.json so it installs @geoext/geoext directly from a github commit, e.g.
"@geoext/geoext": "github:geoext/geoext#53afb79524f7d6bd0374da11c6a8d44ee2951687"

Or another option is to change the karma config so that it doesn't get GeoExt from node_modules, but instead from https://geoext.github.io/geoext3/master/GeoExt.js so it always has access to the latest version.

marcjansen
marcjansen reviewed Mar 30, 2023
View reviewed changes
Copy link
Member

@marcjansen marcjansen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Someone should

  • address the TODOs
  • clean up commits
  • and also this should probably be unmarked as draft

Or is sth. else missing?

src/view/tree/ArcGISRestServiceTree.js Outdated
this.arcGISLayerConfig.service.name,
'json'
);
// TODO requesting service and populating store should
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO Should be addressed please

src/view/tree/ArcGISRestServiceTree.js Outdated
},

onRequestServiceFailure: function (status) {
// TODO: read text from viewmodel or config
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO should be addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcjansen marcjansen marcjansen left review comments

@geographika geographika geographika approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JakobMiksch @fergaldoyle @marcjansen @geographika @jansule