-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shogun helm charts #50
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally: 👍 and nice work @simonseyock
However, some notes regarding helm usage: Did you use an actual helm template (e.g. using helm create shogun-admin
)? Could you please check this again, as the Chart
api version seems to be out of date.
Just as a further idea: Would it make sense to add a chart that combines all the components required for a SHOGun setup in one single chart, so that an working preconfigured SHOGun can be installed via `helm install my-shogun shogun-repo/shogun, for example?
I started from an existing helm chart and used the existing docker-compose as a cross-reference. Good catches. I will update the versions. Currently I am working on pre-configuring the values so each chart can be started one by one and hopefully it will work by default. |
5586003
to
da6721f
Compare
d79020d
to
b451b36
Compare
This introduces helm-charts for the current SHOGun stack.
❗ THIS PR NEEDS TO BE SQUASH MERGED ❗