Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shogun helm charts #50

Merged
merged 41 commits into from
May 6, 2024
Merged

Shogun helm charts #50

merged 41 commits into from
May 6, 2024

Conversation

simonseyock
Copy link
Member

@simonseyock simonseyock commented Jan 31, 2024

This introduces helm-charts for the current SHOGun stack.

❗ THIS PR NEEDS TO BE SQUASH MERGED ❗

Copy link
Member

@ahennr ahennr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally: 👍 and nice work @simonseyock

However, some notes regarding helm usage: Did you use an actual helm template (e.g. using helm create shogun-admin)? Could you please check this again, as the Chart api version seems to be out of date.

Just as a further idea: Would it make sense to add a chart that combines all the components required for a SHOGun setup in one single chart, so that an working preconfigured SHOGun can be installed via `helm install my-shogun shogun-repo/shogun, for example?

charts/shogun-admin/Chart.yaml Outdated Show resolved Hide resolved
charts/shogun-admin/Chart.yaml Outdated Show resolved Hide resolved
charts/shogun-boot/Chart.yaml Outdated Show resolved Hide resolved
@simonseyock
Copy link
Member Author

I started from an existing helm chart and used the existing docker-compose as a cross-reference. Good catches. I will update the versions.

Currently I am working on pre-configuring the values so each chart can be started one by one and hopefully it will work by default.

@KaiVolland KaiVolland marked this pull request as draft March 13, 2024 12:09
@KaiVolland KaiVolland marked this pull request as ready for review March 14, 2024 13:19
charts/shogun/Chart.yaml Outdated Show resolved Hide resolved
charts/shogun/charts/shogun-admin/Chart.yaml Outdated Show resolved Hide resolved
data/keycloak/keycloak_export.json Show resolved Hide resolved
charts/shogun/values.yaml Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@KaiVolland KaiVolland merged commit 7042010 into main May 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants