-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore(next): Include react specific eslint v9 rules #852
Conversation
151117a
to
47ee15b
Compare
…-typescript-react
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, thanks @ahennr!
@@ -57,7 +56,7 @@ const RolePermissionGrid: React.FC<RolePermissionGridProps> = ({ | |||
}; | |||
|
|||
const getRoles = async (pageOpts?: PageOpts) => { | |||
return await client?.role().findAll(pageOpts); | |||
return client?.role().findAll(pageOpts); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure this is correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch! Reverted in 9b7243d
Co-authored-by: Daniel Koch <[email protected]>
🎉 This PR is included in version 17.0.0-next.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
… and cleanup some
babel
plugins that are already included inpreset-env
.Plz review @terrestris/devs