Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore(next): Include react specific eslint v9 rules #852

Merged
merged 3 commits into from
Nov 22, 2024
Merged

Chore(next): Include react specific eslint v9 rules #852

merged 3 commits into from
Nov 22, 2024

Conversation

ahennr
Copy link
Member

@ahennr ahennr commented Oct 21, 2024

… and cleanup some babel plugins that are already included in preset-env.

Plz review @terrestris/devs

@dnlkoch dnlkoch changed the base branch from main to next October 21, 2024 13:03
@ahennr ahennr changed the title Chore: Dependency updates and upgrade to eslint v9 Chore: Include react specific eslint v9 rules Oct 21, 2024
@ahennr ahennr marked this pull request as ready for review October 21, 2024 13:44
@ahennr ahennr changed the title Chore: Include react specific eslint v9 rules Chore(next): Include react specific eslint v9 rules Oct 21, 2024
@ahennr ahennr force-pushed the dev-deps branch 2 times, most recently from 151117a to 47ee15b Compare October 21, 2024 14:39
Copy link
Member

@dnlkoch dnlkoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks @ahennr!

eslint.config.mjs Outdated Show resolved Hide resolved
@@ -57,7 +56,7 @@ const RolePermissionGrid: React.FC<RolePermissionGridProps> = ({
};

const getRoles = async (pageOpts?: PageOpts) => {
return await client?.role().findAll(pageOpts);
return client?.role().findAll(pageOpts);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure this is correct?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Reverted in 9b7243d

@ahennr ahennr merged commit bb864e9 into next Nov 22, 2024
1 check passed
@ahennr ahennr deleted the dev-deps branch November 22, 2024 11:31
Copy link

🎉 This PR is included in version 17.0.0-next.10 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants