Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce buttons to create users, groups and roles from the respective provider #890

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

dnlkoch
Copy link
Member

@dnlkoch dnlkoch commented Nov 11, 2024

This adds a button to each of the User, Group and Role panels to trigger the creation of the given entities from the respective provider (see #947). Generally it just adds all missing entities, e.g. all users that are present in the user provider (usually Keycloak), but not in SHOGun.

Peek 2024-11-11 13-18

In addition this:

  • Refactors the GeneralEntityRoot for more flexible and generic support for entity specific components to render (currently only for the toolbar above the entity table, but this might be adjusted for future needs) by introducing a local context including some props that were shared between all sub components.
  • Fixes a regression of missing support for additional navigation menu entries besides the default ones.

Requires #821.

Please review @terrestris/devs.

…spective provider

In addition it refactors the GeneralEntityRoot for more flexible support for entity
specific components to render and fixes a regression of missing support for additional
navigation menu entries.
@dnlkoch dnlkoch force-pushed the create-entities-from-provider-endpoints branch from 434639e to 76d872a Compare November 11, 2024 17:16
src/i18n/translations.ts Outdated Show resolved Hide resolved
src/i18n/translations.ts Outdated Show resolved Hide resolved
@dnlkoch dnlkoch marked this pull request as ready for review November 12, 2024 18:00
@dnlkoch
Copy link
Member Author

dnlkoch commented Nov 12, 2024

Thanks for the review @LukasLohoff!

@dnlkoch dnlkoch merged commit be2b36a into next Nov 12, 2024
1 check passed
@dnlkoch dnlkoch deleted the create-entities-from-provider-endpoints branch November 12, 2024 18:00
Copy link

🎉 This PR is included in version 17.0.0-next.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants