Merge pull request #864 from terrestris/fix-keycloak-group-extraction

fix: prevent exception when keycloak group does not exist
terrestris · May 21, 2024 · ae033ed · ae033ed
2 parents 83f8ecb + 9fb7732
commit ae033ed
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/...errestris/shogun/lib/service/security/provider/keycloak/KeycloakGroupProviderService.java b/...errestris/shogun/lib/service/security/provider/keycloak/KeycloakGroupProviderService.java
@@ -114,8 +114,9 @@ public List<Group<GroupRepresentation>> getGroupsForUser() {
         List<GroupRepresentation> groupRepresentations = keycloakUtil.getKeycloakUserGroups(user.get());
 
         return (List) groupRepresentations.stream().
-            map(groupRepresentation -> repository.findByAuthProviderId(groupRepresentation.getId()).orElseThrow()).
-            collect(Collectors.toList());
+            map(groupRepresentation -> repository.findByAuthProviderId(groupRepresentation.getId()).orElse(null))
+                .filter(group -> group != null)
+                .collect(Collectors.toList());
     }
 
     public void setTransientRepresentations(Group<GroupRepresentation> group) {