feat: adds app logo in preview on landing page #955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnlkoch
reviewed
Nov 26, 2024
Comment on lines
+183
to
+185
| if (!keycloak.authenticated || !applications) { | ||
| document.querySelector('#app-label-visibility').hidden = false; | ||
| } |
There was a problem hiding this comment.
Indentation seems off and I'm, not quite sure if I get this right, but actually this would show the info message if the user is not logged in or no applications are present? But is there any code/style that hides the message?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add app logo in Kachel in App preview and add warning as to why user cannot preview apps at certain points
Related issues or pull requests
Pull request type
Do you introduce a breaking change?
Checklist
Apache Licence Version 2.0.
mvn testlocally).