fix num of partitions and faiss index file name pattern matching #67
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix issue of number of partitions for the faiss indexing always being 100 and allow using faiss index files with names matching the pattern "ivfpq*.faiss"
Note that when indexing, FAISS may give a warning like this:
WARNING clustering XXX points to YYY centroids
This happens when the sample being indexed has number of data points smaller or bigger than some number.
Apparently, the number of data points(n) must be in range of some multiples of the number of centroids(k). This warning can be silenced but I suppose the ColBERT repo might need an update for this.
More information can be found here.