Image rotation issue fixed on Samsung(S) devices. #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kichiyaki
reviewed
Oct 18, 2020
Comment on lines
+473
to
+482
| ExifInterface exif = null; | ||
| try { | ||
| exif = new ExifInterface(backgroundURI.getPath()); | ||
| } catch (IOException e) { | ||
| e.printStackTrace(); | ||
| } | ||
|
|
||
| int orientation = exif.getAttributeInt(ExifInterface.TAG_ORIENTATION, ExifInterface.ORIENTATION_UNDEFINED); | ||
|
|
||
| Bitmap newBitmap = rotateBitmap(bitmap, orientation); |
There was a problem hiding this comment.
This fragment should be wrapped in the if statement that checks if backgroundURI is null (currently, you can't save an image without background).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on a project, we figured library wasn't working as expected on Samsung(S) devices i.e when we were trying to sketch on image images was being rotated on canvas, so I decided to fork and solve the issue using
ExifInterface. I got the exact rotation of image and then rotated the bitmap that's going on canvas. We tested this code on multiple devices both android and iOS and is working fine.