Rich enums: Remove infused data support and require copyability #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexkaratarakis
changed the title
alexkaratarakis
force-pushed
the
rich_enum_remove_infused_data_support
branch
from
5f3ba4a
to
b54caa9
Compare
alexkaratarakis
changed the title
alexkaratarakis
force-pushed
the
rich_enum_remove_infused_data_support
branch
3 times, most recently
from
9ca0aee
to
1ecb8ed
Compare
1) Users expect "enums" to be small, so allowing members that can increase the size a lot is surprising and can lead to issues and memory waste. 2) If rich enums are cheap, it is not longer necessary to try to do instance control which simplifies implementation and usage
Enums are typically expected to be copyable, so rich enums should be as well. Now that infused/embedded data support is removed, we can rely on rich enums being cheap and copyable.
Now that rich enums are copyable, there is no need to enforce instance control or address equality. Note also that you can't take address of normal enum constants, for example `&TestEnum::ONE` fails to compile.
... instead of std::optional<std::reference_wrapper<const V> This also matches magic_enum::enum_cast<>()
alexkaratarakis
force-pushed
the
rich_enum_remove_infused_data_support
branch
from
1ecb8ed
to
89923df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users expect "enums" to be small, so allowing members that can increase
the size a lot is surprising and can lead to issues and memory waste.
If rich enums are cheap, it is not longer necessary to try to do
instance control which simplifies implementation and usage