Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated all things rustler and implement 128bit integer support #608

Merged
merged 4 commits into from
Jul 12, 2024

Conversation

tessi
Copy link
Owner

@tessi tessi commented Jul 12, 2024

  • updated rustler and rustler_precompiled
  • since these new rustler versions now support 128bit integers, I added support encoding/decoding these to Wasm function calls
  • updated rustler_precompile github action in CI

Changelog: https://github.com/rusterlium/rustler/blob/master/CHANGELOG.md#0340---2024-07-09

Closes: #604
Closes: #605

* updated rustler and rustler_precompiled
* since these new rustler versions now support 128bit integers, I added support encoding/decoding these to Wasm function calls
* updated rustler_precompile github action in CI
native/wasmex/src/instance.rs Outdated Show resolved Hide resolved
lib/wasmex.ex Outdated Show resolved Hide resolved
test/wasmex_test.exs Outdated Show resolved Hide resolved
@tessi
Copy link
Owner Author

tessi commented Jul 12, 2024

@scrogson ahhh, I saw your PR too late and we ended up implementing this upgrade at the same time. Sorry!

From looking at your PR the update we did is basically the same (you did some nicer alias sorting than me here, though). Since I added v128 support in top, I'm inclined to merge this PR and close yours. What do you think?

@tessi tessi merged commit 0dab3d1 into main Jul 12, 2024
23 checks passed
@tessi tessi deleted the tessi/update_rustler branch July 12, 2024 09:48
@tessi tessi mentioned this pull request Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant