bump rustler_precompiled #656
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DnOberon thanks for your PR! 💚 |
|
Oh crap. Can’t believe I forgot that. Will do soon as I’m back home!
…On Wed, Oct 23, 2024 at 7:08 AM Philipp Tessenow ***@***.***> wrote:
@DnOberon <https://github.com/DnOberon> thanks for your PR! 💚
Happy to bump rustler, can you please run mix deps.get to update the
lockfile?
—
Reply to this email directly, view it on GitHub
<#656 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFS4N4YLN37QDJ5Z4DLVETZ457S5AVCNFSM6AAAAABQH3FUJ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZRG42TINZWHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@tessi done! |
|
I'm not sure why the checks are failing @tessi :\ |
|
hmm, weird. I have the same failures on |
|
ahh, it's some multivalue bug - and that feature always was a bit shaky. I'll disable it in main and then do a run around updating all the deps (including this one) |
|
@DnOberon I updated rustler_precompiled and fixed those error (by removing the tests 😅 ). Ended up updating all the things and releasing a new version v0.9.2 Thanks again for opening this PR and being patient with me. It took me until I had a day off work to find the time :) |
|
Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to bump rustler_precomplied so the CA_CERTS env var can be used for HTTP requests.
@tessi - this update is needed so those behind corporate firewalls can use :rustler_precompiled.