Add brackets ([]{}
) to defaultKeyMap for keyboard()/type()
#1226
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Adding support for brackets to address #1225
Why:
To allow easier testing of functionality that relies on both
key
andcode
being valid for keyboard events involving left/right bracketsHow:
Updated
keyMap.ts
, ran the test suite.Checklist:
I'm unclear whether any documentation needs updating, since I imagine this just falls under the heading of the TODO at the bottom of
keyMap.ts
, i.e. this is simply filling out the mappings.Also I considered the updates to the existing tests enough, but it's possibly I ought to add more test cases (namely for the right bracket cases).