Add commitizen changelog generation and automatic release task #138
Conversation
Pull Request Test Coverage Report for Build 9fe0a054ad74d6996c1a4a2e91d140d34bca5e43-PR-138Details
💛 - Coveralls |
| |> Logger.info() | ||
|
|
||
| {"123 feat: some commit\n456 fix: another commit", 0} | ||
| end |
There was a problem hiding this comment.
Time to use something like Mox
Pull Request Test Coverage Report for Build 62aec3021fe7db964e916c870ecada2ba4e64b3a-PR-138Details
💛 - Coveralls |
| collect(rest, %__MODULE__{acc | all: [commit | acc.all], feature: [commit | acc.feature]}) | ||
| end | ||
|
|
||
| defp collect(["BREAKING CHANGE" <> _ = commit | rest], acc) do |
There was a problem hiding this comment.
If I understand correctly the specification, BREAKING CHANGE: is not a valid type for a commit. That is, a commit subject cannot start with BREAKING CHANGE: <description>.
BREAKING CHANGE (or BREAKING-CHANGE) is a valid token to be found in the footer.
If we want to indicate a breaking change by looking only at the first line of the commit, we should look for a ! after the commit type (or scope), like in fix!: some fix that is also a breaking change or fix(parser)!: some fix to the parser that is a breaking change.
Unfortunately, this implies --oneline cannot be used https://github.com/tfiedlerdejanze/expublish/pull/138/files#diff-2c4e7ba552cf4684b4bc0dd08450ff59592e3e8b06e4675ef3aa3f580862f0bbR74 as we need the full commit message to look for a possible BREAKING CHANGE token.
There was a problem hiding this comment.
A naïve attempt to be closer to the spec wrt breaking changes(while still using --oneline for fetching commits): marc0s@ecae0d0
|
I've done a quick test after adding some fixes to a repo and running Allow me to point out some stuff I'm used to after years of using NodeJS'
Thanks for the work and apologizes for my so late review 🙏 |
An intermediate change to fully support the commitizen spec where commit types can be suffixed with `!` to indicate a breaking change. Remove the invalid type `BREAKING CHANGE`. See: tfiedlerdejanze#138 (review)
Resolves #136 and #31