Skip to content

Commit

Permalink
Dedicated parsing into an AST index.
Browse files Browse the repository at this point in the history
Creating an AST is significantly faster than the equivalent
`jsonv::parse` call (approximately 10x speedup). This completely removes
the older `tokenizer` structure and replaces it was a flat `ast_index`
structure.

This commit introduces #145, which calls to revisit `parse_options` and
the associated `parse_error`. Now that the parse phase and extraction to
a JSON `value` are separate, the old configuration options make less
sense. This also enables work on #150, which calls to extract directly
from source text.

- Fixes #147
- Fixes #96 through `ast_node::integer` and `ast_node::decimal`
- Closes #97 by removal of `tokenizer`
  • Loading branch information
tgockel committed Mar 3, 2020
1 parent 526dec2 commit 6e1fcb7
Show file tree
Hide file tree
Showing 53 changed files with 4,207 additions and 3,447 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ nbproject
.settings
composer.lock
*.code-workspace
.vscode

#Cmake
CMakeCache.txt
Expand Down
16 changes: 15 additions & 1 deletion VERSIONS.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,17 @@
2._ Series
==========

2.0
---

- [2.0.0](https://github.com/tgockel/json-voorhees/milestone/12): 2020 March 13
- Core
- Major refactoring of the parsing from the pull-based `tokenizer` into the flat-structured `ast_index`
- Removed support for more lax parser settings -- a parsed `ast_index` has been validated
- Serialization
- Extraction to C++ objects now occurs directly from `ast_index` instead of going through the `value` middle man,
saving time and memory

1._ Series
==========

Expand Down Expand Up @@ -121,7 +135,7 @@ The focus of this release was the creation of tools to traverse and manipulate t
-------------------------------------------------------------------------

The main focus of this release is access and modification of the low-level parsing and encoding system.

- [0.3.1](https://github.com/tgockel/json-voorhees/releases/tag/v0.3.1): 2014 September 27
- Greatly expands the flexibility of `parse_options`
- Adds all the tests from [JSON_Checker](http://json.org/JSON_checker/)
Expand Down
6 changes: 3 additions & 3 deletions doc/conversions.dot
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
digraph jsonv {
label="Conversions"
labelloc="t"
str [label="std::string"]

str [label="std::string\nstd::string_view"]
istream [label="std::istream"]
ostream [label="std::ostream"]
value [label="value", URL="\ref jsonv::value"]
class [label="C++ class"]
dsl [label="C++ DSL"]

value -> str [label="to_string", URL="\ref jsonv::to_string(jsonv::value)"]
value -> ostream [label="operator<<"]
str -> value [label="parse", URL="\ref jsonv::parse"]
Expand Down
Binary file modified doc/conversions.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
60 changes: 29 additions & 31 deletions include/jsonv/algorithm.hpp
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/** \file jsonv/algorithm.hpp
* A collection of algorithms a la `&lt;algorithm&gt;`.
*
*
* Copyright (c) 2014-2018 by Travis Gockel. All rights reserved.
*
* This program is free software: you can redistribute it and/or modify it under the terms of the Apache License
Expand Down Expand Up @@ -32,7 +32,7 @@ class path;

/** Traits describing how to perform various aspects of comparison. This implementation for comparison is strict and is
* ultimately the one used by \c value::compare.
*
*
* \see compare
**/
struct JSONV_PUBLIC compare_traits
Expand All @@ -47,15 +47,15 @@ struct JSONV_PUBLIC compare_traits
int vb = kindval(b);
return va == vb ? 0 : va < vb ? -1 : 1;
}

/** Compare two boolean values. **/
static int compare_booleans(bool a, bool b)
{
return a == b ? 0
: a ? 1
: -1;
}

/** Compare two integer values. **/
static int compare_integers(std::int64_t a, std::int64_t b)
{
Expand All @@ -71,27 +71,27 @@ struct JSONV_PUBLIC compare_traits
: (a < b) ? -1
: 1;
}

/** Compare two string values. **/
static int compare_strings(const std::string& a, const std::string& b)
{
return a.compare(b);
}

/** Compare two strings used for the keys of objects. **/
static int compare_object_keys(const std::string& a, const std::string& b)
{
return a.compare(b);
}

/** Compare two objects \e before comparing the values. The \c compare function will only check the contents of an
* object if this function returns 0.
**/
static int compare_objects_meta(const value&, const value&)
{
return 0;
}

private:
static int kindval(kind k)
{
Expand All @@ -117,18 +117,18 @@ struct JSONV_PUBLIC compare_traits
};

/** Compare the values \a a and \a b using the comparison \a traits.
*
*
* \tparam TCompareTraits A type which should be compatible with the public signatures on the \c compare_traits class.
**/
template <typename TCompareTraits>
int compare(const value& a, const value& b, const TCompareTraits& traits)
{
if (&a == &b)
return 0;

if (int kindcmp = traits.compare_kinds(a.kind(), b.kind()))
return kindcmp;

switch (a.kind())
{
case jsonv::kind::null:
Expand Down Expand Up @@ -158,7 +158,7 @@ int compare(const value& a, const value& b, const TCompareTraits& traits)
{
if (int objmetacmp = traits.compare_objects_meta(a, b))
return objmetacmp;

auto aiter = a.begin_object();
auto biter = b.begin_object();
for ( ; aiter != a.end_object() && biter != b.end_object(); ++aiter, ++biter)
Expand All @@ -176,30 +176,28 @@ int compare(const value& a, const value& b, const TCompareTraits& traits)
}
}

/** Compare the values \a a and \a b with strict comparison traits.
*
* \see value::compare
* \see compare_icase
**/
/// Compare the values \a a and \a b with strict comparison traits.
///
/// \see value::compare
/// \see compare_icase
JSONV_PUBLIC int compare(const value& a, const value& b);

/** Compare the values \a a and \a b, but use case-insensitive matching on \c kind::string values. This does \e not use
* case-insensitive matching on the keys of objects!
*
* \see compare
**/
/// Compare the values \a a and \a b, but use case-insensitive matching on \c kind::string values. This does \e not use
/// case-insensitive matching on the keys of objects!
///
/// \see compare
JSONV_PUBLIC int compare_icase(const value& a, const value& b);

/** The results of the \c diff operation. **/
/// The results of the \c diff operation.
struct JSONV_PUBLIC diff_result
{
/** Elements that were the same between the two halves of the diff. **/
/// Elements that were the same between the two halves of the diff.
value same;

/** Elements that were unique to the left hand side of the diff. **/
/// Elements that were unique to the left hand side of the diff.
value left;

/** Elements that were unique to the right hand side of the diff. **/
/// Elements that were unique to the right hand side of the diff.
value right;
};

Expand All @@ -217,7 +215,7 @@ JSONV_PUBLIC diff_result diff(value left, value right);
* \a input is \c kind::array, \c func is called for every value in the array and the output will be an array with each
* element transformed by \a func. If \a input is \c kind::object, the result will be an object with each key
* transformed by \a func.
*
*
* \param func The function to apply to the element or elements of \a input.
* \param input The value to transform.
**/
Expand All @@ -230,10 +228,10 @@ JSONV_PUBLIC value map(const std::function<value (const value&)>& func,
* \a input is \c kind::array, \c func is called for every value in the array and the output will be an array with each
* element transformed by \a func. If \a input is \c kind::object, the result will be an object with each key
* transformed by \a func.
*
*
* \param func The function to apply to the element or elements of \a input.
* \param input The value to transform.
*
*
* \note
* This version of \c map provides only a basic exception-safety guarantee. If an exception is thrown while
* transforming a non-scalar \c kind, there is no rollback action, so \a input is left in a usable, but
Expand All @@ -245,7 +243,7 @@ JSONV_PUBLIC value map(const std::function<value (value)>& func,
);

/** Recursively walk the provided \a tree and call \a func for each item in the tree.
*
*
* \param tree The JSON value to traverse.
* \param func The function to call for each element in the tree.
* \param base_path The path to prepend to each output path to \a func. This can be useful if beginning traversal from
Expand All @@ -261,7 +259,7 @@ JSONV_PUBLIC void traverse(const value&
);

/** Recursively walk the provided \a tree and call \a func for each item in the tree.
*
*
* \param tree The JSON value to traverse.
* \param func The function to call for each element in the tree.
* \param leafs_only If true, call \a func only when the current path is a "leaf" value (\c string, \c integer,
Expand Down
Loading

0 comments on commit 6e1fcb7

Please sign in to comment.