use npm

thaitype · Mar 12, 2024 · 0369819 · 0369819
1 parent 917eb66
commit 0369819
Show file tree

Hide file tree

Showing 4 changed files with 5,273 additions and 3,086 deletions.
diff --git a/.github/workflows/02-app-service-nodejs-deploy.yml b/.github/workflows/02-app-service-nodejs-deploy.yml
@@ -16,7 +16,7 @@ env:
   PACKAGE_NAME: 'node-app'
   PACKAGE_PATH: 'release.zip'
   NODE_VERSION: '20'
-  PNPM_VERSION: '8'
+  # PNPM_VERSION: '8'
 
 jobs:
   build:
@@ -25,23 +25,23 @@ jobs:
     steps:
       - uses: actions/checkout@v4
 
-      - uses: pnpm/action-setup@v3
-        with:
-          version: ${{ env.PNPM_VERSION }}
+      # - uses: pnpm/action-setup@v3
+      #   with:
+      #     version: ${{ env.PNPM_VERSION }}
 
       - name: Use Node.js ${{ env.NODE_VERSION }}
         uses: actions/setup-node@v4
         with:
           node-version: ${{ env.NODE_VERSION }}
-          cache: 'pnpm'
-          cache-dependency-path: '${{ env.WORKING_DIRECTORY }}/pnpm-lock.yaml'
+          cache: 'npm'
+          cache-dependency-path: '${{ env.WORKING_DIRECTORY }}/package-lock.json'
 
       - name: Install dependencies
-        run: pnpm install --frozen-lockfile
+        run: npm install --production
         working-directory: ${{ env.WORKING_DIRECTORY }}
 
       - name: Build
-        run: pnpm build
+        run: npm run build
         working-directory: ${{ env.WORKING_DIRECTORY }}
 
       - name: Zip artifact for deployment

diff --git a/02-app-service-nodejs/README.md b/02-app-service-nodejs/README.md
@@ -13,3 +13,9 @@ az webapp deploy --resource-group rg-azure-note-ep2 --name thaitype-azure-note-e
 ```
 az webapp deployment source delete --name thaitype-azure-note-ep2 --resource-group rg-azure-note-ep2
 ```
+
+
+## Note
+
+Azure App Service do not support pnpm
+https://github.com/microsoft/Oryx/issues/2340