-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kpath heatmaps with PlotlyJS #24
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #24 +/- ##
==========================================
+ Coverage 84.26% 84.59% +0.33%
==========================================
Files 14 14
Lines 953 987 +34
==========================================
+ Hits 803 835 +32
- Misses 150 152 +2
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Hi Lorenzo, Sorry I forgot this - and thanks for making this PR. I think this is really nice and useful functionality. I wonder though, if it should have a different name than About the Makie question: I had been hoping to provide the same functionality via Makie as we do via PlotlyJS, but only got half-way. |
A minor thing: what is the motivation for having multiple distinct colormaps? The stacking of them with some opacity feels a little arbitrary (i.e., one will partly occlude the other?). |
Hi @thchr, Thank you for reviewing the PR. Sure, I could rename the method Thank you for the explanation on the Makie extension. I may try making some band structure figures and if it goes well I can make a separate PR. Regarding multiple colormaps, I was thinking of using them to highlight different contributions to spectral densities (e.g. interband vs intraband conductivities). The colorscales would have to be chosen well for this to look good, but I thought it would be nice to make it work since PlotlyJS supports it |
Hi, I think the k-path visualization utilities for band plots are great, and I wanted to add a capability for plotting heatmaps, which can be helpful to visualize spectral densities. This pr refactors the k-path plotting code to make this additional capability a straightforward extension of the existing code. An example of what it can do follows from the tutorial in the documentation, which sets up the following
If we now define a spectral density
and evaluate it on a discretization
this pr allows plotting with the following command
and it is also possible to overlay multiple heatmaps with different colors, although what to do with the colorbar in this situation is undefined
I hope this is useful and I am happy to take comments on how to tweak this.
I was also hoping to ask a side question: what does the Makie extension provide?