Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code related to obsolete HW AirPcap #1371

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AndersBroman
Copy link
Contributor

The Riverbed® AirPcap Product has reached End of Availability (EOA) as of December 31, 2017 and it only supports older Windows versions.
https://support.riverbed.com/content/support/software/steelcentral-npm/airpcap.html

The Riverbed® AirPcap Product has reached End of Availability (EOA) as of December 31, 2017
and it only supports older Windows versions.
https://support.riverbed.com/content/support/software/steelcentral-npm/airpcap.html
@infrastation
Copy link
Member

@guyharris, these changes among other things remove the Windows-specific get_airpcap_handle_op_t member from struct pcap, would this require any backward compatibility provisions regarding NPF?

@infrastation
Copy link
Member

These changes also remove a public Windows-specific function from the API:

PCAP_API PAirpcapHandle pcap_get_airpcap_handle(pcap_t *p);

This needs to be considered before merging.

@guyharris
Copy link
Member

These changes also remove a public Windows-specific function from the API:

PCAP_API PAirpcapHandle pcap_get_airpcap_handle(pcap_t *p);

This needs to be considered before merging.

That function should not be removed, so as not to break the ABI.

Instead, it should should probably be modified to fail with an "AirPcap is not supported" error and marked as deprecated.

@guyharris
Copy link
Member

@guyharris, these changes among other things remove the Windows-specific get_airpcap_handle_op_t member from struct pcap, would this require any backward compatibility provisions regarding NPF?

No - neither Npcap nor WinPcap uses that field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants