Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add captured direction in pcap_pkthdr #719

Closed
wants to merge 1 commit into from

Conversation

teknoraver
Copy link

No description provided.

@guyharris
Copy link
Member

This changes a structure in ways that break the ABI; programs using pcap_next() that were built with a version of libpcap without the added member of struct pcap_pkthdr will, if they call pcap_next() when running with a version of libpcap with that member, get data following the structure overwritten.

@guyharris guyharris closed this May 19, 2018
@teknoraver
Copy link
Author

I need this feature to show the direction in tcpdump:

the-tcpdump-group/tcpdump#678

How can we do it without breaking the ABI?

@teknoraver
Copy link
Author

teknoraver commented Nov 24, 2018

I solved it in a different way, I allow to force a cooked capture as the datalink headers often provides this information.

Please see #784

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants