Fix "pppoes" filter for links with variable-length prefix to link header #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
off_outermostlinkhdr doesn't work as expected when "off_outermostlinkhdr.is_variable" (e.g. IEEE_802_11_* links) since registers are allocated only for off_linkhdr (off_outermostlinkhdr.reg will always be -1) Fix this by redefinig off_outermostlinkhdr as pointer to offset of the outermost link header in the link header stack (i.e. either off_linkhdr or off_prevlinkhdr.)
Store prefix lengths generated by gen_load_*_llprefixlen() in the register of off_outermostlinkhdr instead of off_linkhdr. This should fixes a bug for when stacking link headers (as is the case with "pppoes" filter), offset values are stored in off_linkhdr.reg instead of off_prevlinkhdr.reg. gen_load_802_11_header_len should also generate code depending on outermostlinktype instead of linktype.
|
Do you have a sample PCAP file and filter that would exercise this code? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies to all DLT_IEEE_802_11_* link types and should fix #834 .