-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add competency icons #203
Add competency icons #203
Conversation
cool! maybe, after the abbreviations? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the technical side, pandoc is clever enough to wrap the LaTeX code for \faicon
into a \texrorpdfstring
inside of titles, so that no reserved UTF-8 characters appear in the PDF bookmarks (metadata is important for accessibility).
But currently, there is an extra whitespace inside the round brackets in the PDF bookmarks. In addition, the whitespace between the icon and abbreviation is a breaking space, so its easy for an icon to appear at the end of a line and the abbreviation at the beginning of the next line.
One can solve both issues at once with this modification:
diff --git a/competencies.md b/competencies.md
index 71b289f..59cbbfc 100644
--- a/competencies.md
+++ b/competencies.md
@@ -34,3 +34,3 @@ header-includes:
- '\newfontfamily\FA[Path=../fonts/, Extension=.otf]{Font Awesome 6 Free-Solid-900}'
- - \newcommand*{\faicon}[1]{{\FA \symbol{#1}}}
+ - \newcommand*{\faicon}[1]{{\FA \symbol{#1}}~}
xnos-cleveref: True
but one also has to erase all whitespaces, i.e. write \faicon{"F0E8}DOCBB
instead of \faicon{"F0E8} DOCBB
everywhere...
would it also work if I write I'm not a big fan of macros introducing their own whitespace. |
The |
Does f758784 work for you? |
It does, thanks! |
Good news: these icons are also compatible with a glossary via tomncooper/pandoc-gls, should we decide to include one. |
competencies.md
Outdated
@@ -340,7 +356,7 @@ to the FAIR principles. [@ChueHong2014] defines different levels of research | |||
software reusability and the extent to which the software engineering skills | |||
need to be applied to reach them. | |||
|
|||
### Creating documented code building blocks (DOCBB) | |||
### Creating documented code building blocks (\DOCBB) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: LaTeX commands are replaced by an empty string in the PDF bookmarks, so this heading reads "Creating documented code building blocks ()". As a workaround, one can create a dummy LaTeX macro \newcommand{\donothing}[1]{#1}
in header-includes
and write here \donothing{(\DOCBB)}
to prevent the parentheses from appearing in the PDF bookmarks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would also be possible using a construction from #210 that creates section headings from glossary expansions that don't generate links (to avoid issues with hyperref), like so:
% preamble
\newglossaryentry{DOCBB}{name={\faicon{"E4C7}\nobreakspace{}DOCBB},sort={DOCBB},type={skills},
description={Creating documented code building blocks}}
\newcommand{\skillsection}[1]{\hypertarget{skills-#1}{%
\subsubsection{\glsentrydesc{#1} (\glsentrytext{#1})}\label{skills-#1}}}
% body
\skillsection{DOCBB} % instead of `### Creating documented code building blocks (DOCBB)`
Todays call mentioned to use the RC icon for SWLC and a doctorate hat for RC. Might use a light bulb, question mark or brain for NEW (if the that stays). |
How badly do we need to keep using pdflatex or was it just for arXiv? |
So I added the svgs directly, but not sure, what he currently doesn't like about that. He complains about
However, I can compile the MWE \documentclass{article}
\usepackage{svg}
\newcommand*{\SWLC}{\includesvg[width=10pt]{{fonts/arrows-spin}}\nobreakspace{}SWLC}
\begin{document}
\section*{\SWLC}
\SWLC
\end{document} just fine using @jngrad you got an idea? |
I think this is ready for merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an issue with the pdflatex command that triggers fatal errors in the CI pipeline due to permissions. That's an easy fix. There are accessibility issues in the PDF bookmarks, I'll work on it now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like them! But I wonder if their sizing is OK. It looks OK in the tables.
But I feel that the icons are a bit large in the standard Text. They are markedly taller that a capital letter. Is this intentional?
They used to be bigger in the text, and would locally increase the line height. But the last commit introduced a relative height metric so they would be the same height as capital letters. Below is an illustration of the body height with equispaced rulers (red for the baseline and grey for cap height) that shows linespacing isn't affected by icons: |
OK, outdated artifacts link. THis one is from the last: and it looks as intended! Cool! Thanks to both of you! |
@jngrad arxiv doesn't like the required shell-escape of the svg package. Any idea, how I can get pdflatex to use the the already generated .pdf and .pdf_tex files? |
I'm currently in a meeting and can have a look in about 1 hour. Could you try sending ArXiv the converted .pdf files instead of the original .svg files, and drop the shell escape from the build command? |
No worries. It seems that the svg package requires this. Replacing includesvg with imcludeinkscape, i couldn't get that to work. Also the svg package creates some wrapper latex that seems to be used. |
The |
Thank you! |
This adds the icons as presented in #138 (comment) throughout the document and also for the forgotten SP and USERS competencies.
The results can be seen in the compiled artifacts