Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add docker feature #10

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

amltv
Copy link

@amltv amltv commented Aug 2, 2019

also add .gitattributes to exclude some dev requirements

@coveralls
Copy link

coveralls commented Aug 2, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 1992a05 on justcontrol-it:feature-docker into a71a451 on the-tinderbox:master.

@amltv amltv force-pushed the feature-docker branch 3 times, most recently from ff28a8f to 06823e1 Compare August 2, 2019 13:29
@evsign
Copy link
Collaborator

evsign commented Aug 3, 2019

Thanks for the pr!
I don't fully understand what is this for. I assume this is for more easy local development and ci? If this it, can you add readme section about using it and changes to the .travis.yml please?

@amltv
Copy link
Author

amltv commented Aug 5, 2019

Yes, docker needed for easy local development. Our teem use this lib, and we planned push new PR soon, docker help us this it.
Sure, I add readme section. and change travis

@amltv
Copy link
Author

amltv commented Aug 9, 2019

  • added xdebug, needed for coverage.
  • change docker-compose for ci compatibility.
  • add how to run tests with Docker

Please check that travis work perfect, i cant check them!!

P.S. try use phpunit/phpunit docker image but, ccat not work in container. I think it because image based on Alpine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants