One more redirect from Weekly to News

thechangelog · Sep 18, 2023 · e229bae · e229bae
1 parent a0857b0
commit e229bae
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 9 deletions.
diff --git a/lib/changelog_web/controllers/person_controller.ex b/lib/changelog_web/controllers/person_controller.ex
@@ -155,8 +155,12 @@ defmodule ChangelogWeb.PersonController do
     |> render(:show)
   end
 
-  def subscribe(conn = %{method: "GET"}, params = %{"to" => to}) when to in ["weekly", "nightly"] do
-    newsletter = Newsletters.get_by_slug(to)
+  def subscribe(conn = %{method: "GET"}, params = %{"to" => "weekly"}) do
+    redirect(conn, to: ~p"/subscribe/news")
+  end
+
+  def subscribe(conn = %{method: "GET"}, params = %{"to" => "nightly"}) do
+    newsletter = Newsletters.nightly()
 
     conn
     |> assign(:newsletter, newsletter)

diff --git a/lib/changelog_web/templates/person/subscribe_newsletter.html.eex b/lib/changelog_web/templates/person/subscribe_newsletter.html.eex
@@ -6,13 +6,7 @@
     </div>
     <h1 class="signup-heading">You&rsquo;re subscribing to <%= @newsletter.name %></h1>
     <p class="signup-text"><%= @newsletter.description %></p>
-    <p class="signup-text">
-  <%= if @newsletter.slug == "weekly" do %>
-    1 email per week — Delivered on Sundays - <%= link("Archive", to: Routes.page_path(@conn, :weekly_archive)) %>
-  <% else %>
-    7 emails per week — Delivered daily at 10pm US Central
-  <% end %>
-    </p>
+    <p class="signup-text">7 emails per week — Delivered daily at 10pm US Central</p>
   </div>
 </section>