Improve on the Zulip auth app integration #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to reference all secrets from 1Password so that when we need to rotate anything, we simply update the values in 1Password and restart the app so that it reads the new values just-in-time, at boot time. FTR: - thechangelog#492 (comment) Signed-off-by: Gerhard Lazu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to reference all secrets from 1Password so that when we need to rotate anything, we simply update the values in 1Password and restart the app so that it reads the new values just-in-time, at boot time.
FTR:
AFTER this gets merged & deployed into production:
flyctl secrets unset ZULIP_ADMIN_USER ZULIP_ADMIN_API_KEY ZULIP_USER ZULIP_API_KEY ZULIP_BOT_USER ZULIP_BOT_API_KEY