Apple silicon #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angerman
force-pushed
the
apple-silicon
branch
from
3d7b0b2 to
6c3878b
Compare
21 tasks
thefloweringash
force-pushed
the
apple-silicon
branch
4 times, most recently
from
5d9a29b to
081038b
Compare
Instead of always supplying flags, apply the flags as defaults. Use clang's native flags instead of lifting the linker flags from binutils with `-Wl,`. If a project is using clang to drive linking, make clang do the right thing with MACOSX_DEPLOYMENT_TARGET. This can be overridden by command line arguments. This will cause modern clang to pass `-platform_version 10.12 0.0.0`, since it doesn't know about the SDK settings. Older versions of clang will pass down `-macos_version_min` flags with no sdk version. At the linker layer, apply a default value for anything left ambiguous. If nothing is specified, pass a full `-platform_version`. If only `-macos_version_min` is specified, then lock down the sdk_version explicitly with `-sdk_version`. If a min version and sdk version is passed, do nothing.
angerman
force-pushed
the
apple-silicon
branch
from
f5e4463 to
5225214
Compare
This avoids contamination via MACSOX_DEPLOYMENT_TARGET when cross compiling.
It's not clear why this is required, but glib includes CoreServices headers and calls CoreServices functions, so it's reasonable to link against the framework explicitly.
thefloweringash
force-pushed
the
apple-silicon
branch
from
aa65ced to
5c2f549
Compare
Eases bootstrapping on darwin, since it doesn't require running libtoolize in stage1.
thefloweringash
force-pushed
the
apple-silicon
branch
from
b41644c to
66211f5
Compare
angerman
force-pushed
the
apple-silicon
branch
from
257cb12 to
75f7281
Compare
thefloweringash
force-pushed
the
apple-silicon
branch
from
6212c29 to
03753d7
Compare
thefloweringash
force-pushed
the
apple-silicon
branch
from
abe9007 to
d40b824
Compare
thefloweringash
force-pushed
the
apple-silicon
branch
from
6cd3b0a to
fd6d7af
Compare
thefloweringash
force-pushed
the
apple-silicon
branch
7 times, most recently
from
6f75766 to
e8beb34
Compare
thefloweringash
force-pushed
the
apple-silicon
branch
3 times, most recently
from
868d348 to
56fcbcd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)