Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rubygem-base64 package #11097

Closed
wants to merge 1 commit into from
Closed

Conversation

ehelms
Copy link
Member

@ehelms ehelms commented Aug 5, 2024

No description provided.

@evgeni
Copy link
Member

evgeni commented Aug 13, 2024

isn't that a std gem that is only required in 3.3+?

@ehelms
Copy link
Member Author

ehelms commented Aug 13, 2024

Good question.... is autorequires doing dumb things?

[2024-08-13T12:22:03.254Z]         Error: Repoclosure ended with unresolved dependencies (1) across 1 packages.
[2024-08-13T12:22:03.254Z]         package: rubygem-jwt-2.8.2-1.el8.noarch from repo0
[2024-08-13T12:22:03.254Z]           unresolved deps (1):
[2024-08-13T12:22:03.254Z]             rubygem(base64)

@evgeni
Copy link
Member

evgeni commented Aug 13, 2024

It's not doing totally dumb things.

  • jwt added a dep on base64 (deps in gems are ruby-agnostic)
  • autoreq doesn't know base64 can be resolved internally, and adds the dep
  • we have to use %gemspec_remove_dep to drop that

@ekohl
Copy link
Member

ekohl commented Aug 13, 2024

Looking at https://stdgems.org/ then we see that Ruby 3.3 and earlier all list base64 as a default gem. https://docs.ruby-lang.org/en/master/NEWS_md.html does mention it will turn into a bundled gem.

You should use %gemspec_remove_dep base64 to drop it from the gemspec and manually add a dependency on ruby-default-gems as a rich dependency: (rubygem(base64) or ruby-default-gems < 3.4). That way we will be ready when we get to Ruby 3.4.

@ehelms
Copy link
Member Author

ehelms commented Aug 13, 2024

Looking at https://stdgems.org/ then we see that Ruby 3.3 and earlier all list base64 as a default gem. https://docs.ruby-lang.org/en/master/NEWS_md.html does mention it will turn into a bundled gem.

You should use %gemspec_remove_dep base64 to drop it from the gemspec and manually add a dependency on ruby-default-gems as a rich dependency: (rubygem(base64) or ruby-default-gems < 3.4). That way we will be ready when we get to Ruby 3.4.

I am trying to capture this into the docs for future reference -- #11119

@ehelms ehelms closed this Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants