add jquery-ui-rails package to katello #11416
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamruzicka
approved these changes
Oct 31, 2024
|
Needs a rebase |
MariaAga
force-pushed
the
add-jquery-ui-katello
branch
from
a1a2163
to
f530f2d
Compare
|
Rebased |
|
And once more I'm afraid |
MariaAga
force-pushed
the
add-jquery-ui-katello
branch
2 times, most recently
from
c5d55a3
to
272c8bc
Compare
|
@theforeman/packaging |
|
[test rpm-copr] |
|
Sigh, if I'm reading it right, rebasing once more should make the current build failures go away. |
|
unfourtunetly |
|
[test rpm-copr] |
MariaAga
force-pushed
the
add-jquery-ui-katello
branch
from
272c8bc
to
c49732f
Compare
|
Rebased again |
ekohl
requested changes
Dec 2, 2024
| @@ -76,6 +76,10 @@ BuildRequires: (npm(react-bootstrap) >= 0.32.1 with npm(react-bootstrap) < 1.0.0 | |||
| BuildRequires: (npm(use-deep-compare-effect) >= 1.6.1 with npm(use-deep-compare-effect) < 2.0.0) | |||
| # end package.json dependencies BuildRequires | |||
|
|
|||
| # start specfile assets BuildRequires | |||
There was a problem hiding this comment.
This would point to an assets bundler group like Foreman has (https://github.com/theforeman/foreman/blob/207137e04d1c87757477d758c20d0790de142173/bundler.d/assets.rb#L1), but katello doesn't use that. Instead, in Katello/katello#10982 you add it to the gemspec so it belongs in the specfile generated dependencies group.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
split from #11004