Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foreman Client el10 build support #11532

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

pcreech
Copy link
Member

@pcreech pcreech commented Dec 3, 2024

No description provided.

@pcreech pcreech requested a review from a team as a code owner December 3, 2024 16:54
Copy link
Member

@evgeni evgeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conceptually this looks fine. Just remarks about the list of packages.

comps/comps-foreman-client-el10.xml Outdated Show resolved Hide resolved
comps/comps-foreman-client-el10.xml Outdated Show resolved Hide resolved
comps/comps-foreman-client-el10.xml Show resolved Hide resolved
comps/comps-foreman-client-el10.xml Outdated Show resolved Hide resolved
<packagelist>
<packagereq type="default">foreman-client-release</packagereq>
<packagereq type="default">foreman_ygg_migration</packagereq>
<packagereq type="default">foreman_ygg_worker</packagereq>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamruzicka this fails to build on EL10:
https://download.copr.fedorainfracloud.org/results/evgeni/el10/centos-stream-10-x86_64/08343540-foreman_ygg_worker/builder-live.log.gz

Shouldn't block this PR, but something that will end up on your plate one day ;)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copying discussion from Matrix: after #11493 is merged we can investigate using the proper go macros to build. Those weren't available on EL7.

@pcreech
Copy link
Member Author

pcreech commented Dec 10, 2024

Updated :D

@evgeni evgeni merged commit 31a319b into theforeman:rpm/develop Dec 11, 2024
2 checks passed
@evgeni
Copy link
Member

evgeni commented Dec 11, 2024

I have built katello-host-tools katello-pull-transport-migrate rubygem-foreman_scap_client foreman-release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants