drop confirmation for online backups -- these are now supported

theforeman · Aug 13, 2024 · bc04587 · bc04587
1 parent fdb2c09
commit bc04587
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 35 deletions.
diff --git a/definitions/procedures/backup/online/safety_confirmation.rb b/definitions/procedures/backup/online/safety_confirmation.rb
diff --git a/definitions/scenarios/backup.rb b/definitions/scenarios/backup.rb
@@ -22,7 +22,6 @@ def compose
         :online_backup => strategy == :online)
       add_step(Checks::ForemanTasks::NotRunning.new(:wait_for_tasks => wait_for_tasks?))
       add_step(Checks::Pulpcore::NoRunningTasks.new(:wait_for_tasks => wait_for_tasks?))
-      safety_confirmation
       add_step_with_context(Procedures::Backup::AccessibilityConfirmation) if strategy == :offline
       add_step_with_context(Procedures::Backup::PrepareDirectory)
       add_step_with_context(Procedures::Backup::Metadata, :online_backup => strategy == :online)
@@ -65,12 +64,6 @@ def set_context_mapping
 
     private
 
-    def safety_confirmation
-      if strategy == :online
-        add_step_with_context(Procedures::Backup::Online::SafetyConfirmation)
-      end
-    end
-
     def check_valid_strategy
       unless [:online, :offline].include? strategy
         raise ArgumentError, "Unsupported strategy '#{strategy}'"

diff --git a/test/definitions/scenarios/backup_test.rb b/test/definitions/scenarios/backup_test.rb
@@ -91,7 +91,6 @@ module Scenarios
         checks.each do |check|
           assert_scenario_has_step(scenario, check)
         end
-        assert_scenario_has_step(scenario, Procedures::Backup::Online::SafetyConfirmation)
         refute_scenario_has_step(scenario, Procedures::Backup::AccessibilityConfirmation)
         assert_scenario_has_step(scenario, Procedures::Backup::PrepareDirectory)
         assert_scenario_has_step(scenario, Procedures::Backup::Metadata)