-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic tests using packit #818
base: master
Are you sure you want to change the base?
Conversation
@@ -1,24 +0,0 @@ | |||
name: Ruby Tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does this file get removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note it's in the last [WIP]
commit. Just to avoid spending extra cycles just iterating on something unrelated.
I opened teemtee/tmt#2825 for some guidance on best practices for repository handling. |
@Griffin-Sullivan locally I could run this with |
- hostname | ||
- foreman-maintain | ||
execute: | ||
- script: foreman-maintain --help |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know why --help
triggers hostname?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. It's either this:
foreman_maintain/lib/foreman_maintain/concerns/system_helpers.rb
Lines 94 to 96 in cfbb8c4
def hostname | |
execute('hostname -f') | |
end |
But more likely this:
@foreman_url = @options.fetch(:foreman_url, `hostname -f`.chomp) |
That latter should really use block form:
@foreman_url = @options.fetch(:foreman_url) { `hostname -f`.chomp }
That way it doesn't execute hostname -f
if a value is found.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could, in theory, use this PR to test both this PR and the theory? By including these pieces of code selectively commented out and removing the hostname requires. Kind of a fun experiment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#819. And there's already plenty of other things I'm trying to test. First I just want it to work.
It's failing to install. I suspect it's trying to install the package before the repository with our packages is set up.
|
The aim of this is to run tests on the built RPM to verify various scenarios using real systems.