always use pg_dump for DB backups #893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeni
commented
Jun 26, 2024
| for_feature :candlepin_database | ||
| preparation_steps { Checks::Candlepin::DBUp.new unless feature(:candlepin_database).local? } | ||
| param :backup_dir, 'Directory where to backup to', :required => true | ||
| param :tar_volume_size, 'Size of tar volume (indicates splitting)' |
There was a problem hiding this comment.
It's funny this was defined, but never passed to the procedure (heck, even the CLI param is called --split-pulp-tar), so yay less unused complexity?
Gotta find out how to move that check to the prep steps. |
ehelms
approved these changes
Jul 2, 2024
evgeni
force-pushed
the
always-dump
branch
2 times, most recently
from
7f98178 to
3f8dfb4
Compare
|
@evgeni Are you holding on merge to perform testing first? |
|
Yeah, we were trying to run tests and they ended up red, so … waiting |
when restoring incremental backups, you can run in the situation where the on-disk representation of the database changes between the restore of the base and the increment, leading to a broken database. by using logical DB dumps, we ensure that the restore always work at the cost that increments are slightly bigger as they now always include a full DB dump this also allows simplification of the code as we now only have one type of DB backup to support
|
ah, nice. aaac56d did actually break things for this PR \o/ |
ehelms
approved these changes
Jul 19, 2024
evgeni
added a commit
to evgeni/forklift
that referenced
this pull request
Jul 24, 2024
theforeman/foreman_maintain#893 switched the db backups to dump
ekohl
pushed a commit
to theforeman/forklift
that referenced
this pull request
Jul 24, 2024
theforeman/foreman_maintain#893 switched the db backups to dump
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
includes #891 for the checks