-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add usage reports #928
base: master
Are you sure you want to change the base?
Add usage reports #928
Commits on May 23, 2024
-
Allow report generating in the foreman-maintain
This extends the check so it can hold any arbitrary data. That is then used in the generate report command, that finds all checks tagged with report tag, executes them and gather their data for the final YAML creation. This commit also includes two examples of metrics that uses database as the Data source.
Configuration menu - View commit details
-
Copy full SHA for 46ba461 - Browse repository at this point
Copy the full SHA 46ba461View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b12733 - Browse repository at this point
Copy the full SHA 5b12733View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4e47536 - Browse repository at this point
Copy the full SHA 4e47536View commit details -
Configuration menu - View commit details
-
Copy full SHA for 84f1d75 - Browse repository at this point
Copy the full SHA 84f1d75View commit details -
Configuration menu - View commit details
-
Copy full SHA for c0a8fe1 - Browse repository at this point
Copy the full SHA c0a8fe1View commit details -
Configuration menu - View commit details
-
Copy full SHA for a6877cf - Browse repository at this point
Copy the full SHA a6877cfView commit details -
Configuration menu - View commit details
-
Copy full SHA for b313a76 - Browse repository at this point
Copy the full SHA b313a76View commit details -
Introduce ReportCheck subtype used only for reporting purpose
With this new child class, report checks can share helpers easily. Also the parent Check class, which is used elsewhere, does not need to be extended by the data storage.
Configuration menu - View commit details
-
Copy full SHA for dd0a81c - Browse repository at this point
Copy the full SHA dd0a81cView commit details -
Extract Reports as a new entity
Earlier, all Reports were also considered Checks, so they showed up in health checks. This change now fully isolates Reports and Checks while all the code is shared.
Configuration menu - View commit details
-
Copy full SHA for 9d562b1 - Browse repository at this point
Copy the full SHA 9d562b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 11834a8 - Browse repository at this point
Copy the full SHA 11834a8View commit details
Commits on Jun 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c4c9019 - Browse repository at this point
Copy the full SHA c4c9019View commit details
Commits on Jun 18, 2024
-
Merge pull request theforeman#1 from adamruzicka/report-rl
Add recurring logics report
Configuration menu - View commit details
-
Copy full SHA for 42bf4cf - Browse repository at this point
Copy the full SHA 42bf4cfView commit details
Commits on Jun 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7993b16 - Browse repository at this point
Copy the full SHA 7993b16View commit details
Commits on Jul 23, 2024
-
Merge pull request theforeman#3 from adamruzicka/report-grouping
Add grouping report
Configuration menu - View commit details
-
Copy full SHA for 5915956 - Browse repository at this point
Copy the full SHA 5915956View commit details
Commits on Oct 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 12073c5 - Browse repository at this point
Copy the full SHA 12073c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 92d9ed2 - Browse repository at this point
Copy the full SHA 92d9ed2View commit details -
don't backup /usr/share/foreman/bundler.d/katello.rb
no idea why this was ever there
Configuration menu - View commit details
-
Copy full SHA for 7fb95b9 - Browse repository at this point
Copy the full SHA 7fb95b9View commit details -
we do not deploy dynflowd, only dynflow_sidekiq since https://projects.theforeman.org/issues/28421 (RPM) https://projects.theforeman.org/issues/28068 (DEB)
Configuration menu - View commit details
-
Copy full SHA for 17323dd - Browse repository at this point
Copy the full SHA 17323ddView commit details -
Add reindexing manifest metadata into katello to ContainerHandleImage…
…Metadata command
Configuration menu - View commit details
-
Copy full SHA for a5fe89d - Browse repository at this point
Copy the full SHA a5fe89dView commit details -
Configuration menu - View commit details
-
Copy full SHA for bfb9f43 - Browse repository at this point
Copy the full SHA bfb9f43View commit details -
Configuration menu - View commit details
-
Copy full SHA for a3f28ba - Browse repository at this point
Copy the full SHA a3f28baView commit details -
Configuration menu - View commit details
-
Copy full SHA for c325179 - Browse repository at this point
Copy the full SHA c325179View commit details -
Don't exclude things during restore
We already excluded them during backup, so there is nothing to exclude during restore and we do not support restoring from backups of super old versions that did not exlude things.
Configuration menu - View commit details
-
Copy full SHA for 3ed662d - Browse repository at this point
Copy the full SHA 3ed662dView commit details -
Configuration menu - View commit details
-
Copy full SHA for d54d8c1 - Browse repository at this point
Copy the full SHA d54d8c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 02a03fc - Browse repository at this point
Copy the full SHA 02a03fcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 68383b0 - Browse repository at this point
Copy the full SHA 68383b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for d78d6e9 - Browse repository at this point
Copy the full SHA d78d6e9View commit details -
Don't reset Candlepin migrations during restore
This marker file was removed in theforeman/puppet-candlepin@18bca42 and Candlepin now manages its migrations on its own.
Configuration menu - View commit details
-
Copy full SHA for a3adeb7 - Browse repository at this point
Copy the full SHA a3adeb7View commit details -
Don't migrate Pulpcore during restore
The installer will do that for us already, no need to duplicate work.
Configuration menu - View commit details
-
Copy full SHA for 2a0e771 - Browse repository at this point
Copy the full SHA 2a0e771View commit details -
don't backup postgresql.service
1/ it's not present in most cases 2/ even if it was, puppet/installer would manage it just fine
Configuration menu - View commit details
-
Copy full SHA for d7341df - Browse repository at this point
Copy the full SHA d7341dfView commit details -
don't backup dynflow_sidekiq service symlinks
This was introduced in 8fda535 and later changed in e6547a9 but it never has matched a file as the symlinks are `dynflow_sidekiq@<instance>.service` while the code only looked for `<instance>.service` Given nobody complained about dynflow not working after a restore in the last 4 years, I am rather sure we can just not back those up and still be happy.
Configuration menu - View commit details
-
Copy full SHA for 8fa5847 - Browse repository at this point
Copy the full SHA 8fa5847View commit details -
always validate hostname from metadata
We introduced this metadata field in theforeman#536 which landed in 0.9.1, which is old enough to rely on and not care for backups that don't have this metadata field
Configuration menu - View commit details
-
Copy full SHA for 713d073 - Browse repository at this point
Copy the full SHA 713d073View commit details -
don't start services or reload systemd after restore
1/ reloading of systemd should come before starting services 2/ we don't backup any systemd files, so a reload is not required 3/ the installer will start all required services for us
Configuration menu - View commit details
-
Copy full SHA for 25dd033 - Browse repository at this point
Copy the full SHA 25dd033View commit details -
don't make pulpcore optional in backups
when we were in the pulp 2to3 migration, users could end up with backup that had both pulp2 and pulp3 databases, but only really had to restore pulp2. now that pulp2 is gone, we can always assume that if a backup has pulpcore DB, the user wants it restored
Configuration menu - View commit details
-
Copy full SHA for e1c4d39 - Browse repository at this point
Copy the full SHA e1c4d39View commit details -
Configuration menu - View commit details
-
Copy full SHA for ec053fc - Browse repository at this point
Copy the full SHA ec053fcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 725a934 - Browse repository at this point
Copy the full SHA 725a934View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2041555 - Browse repository at this point
Copy the full SHA 2041555View commit details -
Configuration menu - View commit details
-
Copy full SHA for ebca8f0 - Browse repository at this point
Copy the full SHA ebca8f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2cc43d5 - Browse repository at this point
Copy the full SHA 2cc43d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for cdc46c7 - Browse repository at this point
Copy the full SHA cdc46c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3c9d152 - Browse repository at this point
Copy the full SHA 3c9d152View commit details -
Configuration menu - View commit details
-
Copy full SHA for f4bde26 - Browse repository at this point
Copy the full SHA f4bde26View commit details -
Configuration menu - View commit details
-
Copy full SHA for ce4ca3d - Browse repository at this point
Copy the full SHA ce4ca3dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 04d60a9 - Browse repository at this point
Copy the full SHA 04d60a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9252965 - Browse repository at this point
Copy the full SHA 9252965View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1553ff5 - Browse repository at this point
Copy the full SHA 1553ff5View commit details -
Configuration menu - View commit details
-
Copy full SHA for cb68266 - Browse repository at this point
Copy the full SHA cb68266View commit details -
Configuration menu - View commit details
-
Copy full SHA for a25bba5 - Browse repository at this point
Copy the full SHA a25bba5View commit details -
Configuration menu - View commit details
-
Copy full SHA for bc19db7 - Browse repository at this point
Copy the full SHA bc19db7View commit details -
Configuration menu - View commit details
-
Copy full SHA for ce85f4c - Browse repository at this point
Copy the full SHA ce85f4cView commit details -
Configuration menu - View commit details
-
Copy full SHA for b450397 - Browse repository at this point
Copy the full SHA b450397View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8cdc860 - Browse repository at this point
Copy the full SHA 8cdc860View commit details -
Configuration menu - View commit details
-
Copy full SHA for 405d4d3 - Browse repository at this point
Copy the full SHA 405d4d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for d0c35ce - Browse repository at this point
Copy the full SHA d0c35ceView commit details -
Configuration menu - View commit details
-
Copy full SHA for ff9b4f3 - Browse repository at this point
Copy the full SHA ff9b4f3View commit details -
Don't disable maintenance mode in BackupRescue scenario
We don't enable maintenance mode anymore for backups, so we don't need to disable it. Fixes: f0e78f7
Configuration menu - View commit details
-
Copy full SHA for e96d85e - Browse repository at this point
Copy the full SHA e96d85eView commit details -
Configuration menu - View commit details
-
Copy full SHA for b34cd74 - Browse repository at this point
Copy the full SHA b34cd74View commit details -
Configuration menu - View commit details
-
Copy full SHA for 241e828 - Browse repository at this point
Copy the full SHA 241e828View commit details -
only chown to postgres group for online backups with local DB
all others do not need the postgres user to be able to read the backup for restore
Configuration menu - View commit details
-
Copy full SHA for ce42c23 - Browse repository at this point
Copy the full SHA ce42c23View commit details -
Configuration menu - View commit details
-
Copy full SHA for f3196a1 - Browse repository at this point
Copy the full SHA f3196a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4ebaa08 - Browse repository at this point
Copy the full SHA 4ebaa08View commit details -
don't fail upstream update with "undefined method `current_minor_vers…
…ion'" [root@centos8-stream-katello-nightly ~]# foreman-maintain update check Checking for new version of rubygem-foreman_maintain... Nothing to update, can't find new version of rubygem-foreman_maintain. undefined method `current_minor_version' for nil:NilClass I, [2024-06-25 11:46:51+0000 #12497] INFO -- : Running foreman-maintain command with arguments [["update", "check"]] E, [2024-06-25 11:46:54+0000 #12497] ERROR -- : undefined method `current_minor_version' for nil:NilClass (NoMethodError) /usr/share/gems/gems/foreman_maintain-1.6.10/definitions/scenarios/satellite_upgrade.rb:7:in `block (2 levels) in upgrade_metadata' /usr/share/gems/gems/foreman_maintain-1.6.10/lib/foreman_maintain/concerns/metadata.rb:230:in `instance_exec' /usr/share/gems/gems/foreman_maintain-1.6.10/lib/foreman_maintain/concerns/metadata.rb:230:in `block in evaluate_confines' /usr/share/gems/gems/foreman_maintain-1.6.10/lib/foreman_maintain/concerns/metadata.rb:229:in `all?' /usr/share/gems/gems/foreman_maintain-1.6.10/lib/foreman_maintain/concerns/metadata.rb:229:in `evaluate_confines' /usr/share/gems/gems/foreman_maintain-1.6.10/lib/foreman_maintain/concerns/metadata.rb:204:in `present?' /usr/share/gems/gems/foreman_maintain-1.6.10/lib/foreman_maintain/detector.rb:62:in `block in available_scenarios' /usr/share/gems/gems/foreman_maintain-1.6.10/lib/foreman_maintain/detector.rb:61:in `select' /usr/share/gems/gems/foreman_maintain-1.6.10/lib/foreman_maintain/detector.rb:61:in `available_scenarios' /usr/share/gems/gems/foreman_maintain-1.6.10/lib/foreman_maintain/concerns/finders.rb:29:in `find_scenarios' /usr/share/gems/gems/foreman_maintain-1.6.10/lib/foreman_maintain/update_runner.rb:25:in `find_scenario' /usr/share/gems/gems/foreman_maintain-1.6.10/lib/foreman_maintain/update_runner.rb:74:in `run_phase' /usr/share/gems/gems/foreman_maintain-1.6.10/lib/foreman_maintain/cli/update_command.rb:30:in `execute' /usr/share/gems/gems/clamp-1.3.2/lib/clamp/command.rb:66:in `run' /usr/share/gems/gems/clamp-1.3.2/lib/clamp/subcommand/execution.rb:18:in `execute' /usr/share/gems/gems/clamp-1.3.2/lib/clamp/command.rb:66:in `run' /usr/share/gems/gems/clamp-1.3.2/lib/clamp/subcommand/execution.rb:18:in `execute' /usr/share/gems/gems/clamp-1.3.2/lib/clamp/command.rb:66:in `run' /usr/share/gems/gems/foreman_maintain-1.6.10/lib/foreman_maintain/cli.rb:40:in `run' /usr/share/gems/gems/clamp-1.3.2/lib/clamp/command.rb:140:in `run' /usr/share/gems/gems/foreman_maintain-1.6.10/bin/foreman-maintain:15:in `<top (required)>' /bin/foreman-maintain:23:in `load' /bin/foreman-maintain:23:in `<main>'
Configuration menu - View commit details
-
Copy full SHA for a8f58e1 - Browse repository at this point
Copy the full SHA a8f58e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 363833b - Browse repository at this point
Copy the full SHA 363833bView commit details -
Configuration menu - View commit details
-
Copy full SHA for d884e3a - Browse repository at this point
Copy the full SHA d884e3aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 438ab21 - Browse repository at this point
Copy the full SHA 438ab21View commit details -
Configuration menu - View commit details
-
Copy full SHA for df4deed - Browse repository at this point
Copy the full SHA df4deedView commit details -
Configuration menu - View commit details
-
Copy full SHA for 830bbfa - Browse repository at this point
Copy the full SHA 830bbfaView commit details -
Configuration menu - View commit details
-
Copy full SHA for f7202d4 - Browse repository at this point
Copy the full SHA f7202d4View commit details -
Heredoc has been supported since Ruby 2.3 and the gemspec already mandates Ruby 2.7+.
Configuration menu - View commit details
-
Copy full SHA for 32b2834 - Browse repository at this point
Copy the full SHA 32b2834View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f52bad - Browse repository at this point
Copy the full SHA 6f52badView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d7ffe7 - Browse repository at this point
Copy the full SHA 0d7ffe7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8079f29 - Browse repository at this point
Copy the full SHA 8079f29View commit details -
Configuration menu - View commit details
-
Copy full SHA for e90ed06 - Browse repository at this point
Copy the full SHA e90ed06View commit details -
Auto-detect if colors are supported
Not all output supports colors. For example, cron doesn't. This copies the autodetection from Kafo to disable colors if needed.
Configuration menu - View commit details
-
Copy full SHA for 071b412 - Browse repository at this point
Copy the full SHA 071b412View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6fda0f2 - Browse repository at this point
Copy the full SHA 6fda0f2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8f86b09 - Browse repository at this point
Copy the full SHA 8f86b09View commit details -
Configuration menu - View commit details
-
Copy full SHA for be74710 - Browse repository at this point
Copy the full SHA be74710View commit details -
Configuration menu - View commit details
-
Copy full SHA for 730b504 - Browse repository at this point
Copy the full SHA 730b504View commit details -
always use pg_dump for DB backups
when restoring incremental backups, you can run in the situation where the on-disk representation of the database changes between the restore of the base and the increment, leading to a broken database. by using logical DB dumps, we ensure that the restore always work at the cost that increments are slightly bigger as they now always include a full DB dump this also allows simplification of the code as we now only have one type of DB backup to support
Configuration menu - View commit details
-
Copy full SHA for b21563e - Browse repository at this point
Copy the full SHA b21563eView commit details -
Configuration menu - View commit details
-
Copy full SHA for c3ba01d - Browse repository at this point
Copy the full SHA c3ba01dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a040d1 - Browse repository at this point
Copy the full SHA 6a040d1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 15be028 - Browse repository at this point
Copy the full SHA 15be028View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3d3e1e7 - Browse repository at this point
Copy the full SHA 3d3e1e7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e98371 - Browse repository at this point
Copy the full SHA 1e98371View commit details -
Configuration menu - View commit details
-
Copy full SHA for bbee42a - Browse repository at this point
Copy the full SHA bbee42aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c00ca7 - Browse repository at this point
Copy the full SHA 9c00ca7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 37a976e - Browse repository at this point
Copy the full SHA 37a976eView commit details -
Configuration menu - View commit details
-
Copy full SHA for da67ffd - Browse repository at this point
Copy the full SHA da67ffdView commit details -
check for running tasks before a backup is done
optionally allow waiting for them to complete
Configuration menu - View commit details
-
Copy full SHA for 58a6d87 - Browse repository at this point
Copy the full SHA 58a6d87View commit details -
stop workers during online backup
this ensures more consistent on-disk data
Configuration menu - View commit details
-
Copy full SHA for 009ace3 - Browse repository at this point
Copy the full SHA 009ace3View commit details -
Configuration menu - View commit details
-
Copy full SHA for f766439 - Browse repository at this point
Copy the full SHA f766439View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ec43ce - Browse repository at this point
Copy the full SHA 9ec43ceView commit details -
Configuration menu - View commit details
-
Copy full SHA for 69d18a8 - Browse repository at this point
Copy the full SHA 69d18a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for f729c37 - Browse repository at this point
Copy the full SHA f729c37View commit details -
don't conditionally add Procedures::Crond::* during restore
the procedures are already confined via `for_feature :cron`
Configuration menu - View commit details
-
Copy full SHA for b687688 - Browse repository at this point
Copy the full SHA b687688View commit details -
Configuration menu - View commit details
-
Copy full SHA for b162487 - Browse repository at this point
Copy the full SHA b162487View commit details -
don't check for both manage_crond config option and cron feature
the feature is already confined to that option being true
Configuration menu - View commit details
-
Copy full SHA for c5284a0 - Browse repository at this point
Copy the full SHA c5284a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 81476a7 - Browse repository at this point
Copy the full SHA 81476a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for be805ae - Browse repository at this point
Copy the full SHA be805aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d63be8 - Browse repository at this point
Copy the full SHA 8d63be8View commit details -
Drop --target-version parameter
This parameter is no longer used by the upgrade runner as it is defined internally by the scenarios.
Configuration menu - View commit details
-
Copy full SHA for 48d4970 - Browse repository at this point
Copy the full SHA 48d4970View commit details -
Configuration menu - View commit details
-
Copy full SHA for 68a0ecc - Browse repository at this point
Copy the full SHA 68a0eccView commit details -
properly confine the pulpcore feature
otherwise it is present on Foreman setups and might break things
Configuration menu - View commit details
-
Copy full SHA for d61ba01 - Browse repository at this point
Copy the full SHA d61ba01View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a04a33 - Browse repository at this point
Copy the full SHA 1a04a33View commit details -
Configuration menu - View commit details
-
Copy full SHA for 090792b - Browse repository at this point
Copy the full SHA 090792bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4fc1c53 - Browse repository at this point
Copy the full SHA 4fc1c53View commit details -
Configuration menu - View commit details
-
Copy full SHA for 95e6f59 - Browse repository at this point
Copy the full SHA 95e6f59View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1ae3df9 - Browse repository at this point
Copy the full SHA 1ae3df9View commit details -
Configuration menu - View commit details
-
Copy full SHA for d8267e0 - Browse repository at this point
Copy the full SHA d8267e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 24d4dee - Browse repository at this point
Copy the full SHA 24d4deeView commit details -
Implement "restart" for RemoteDB services
It's not really a restart, as we can't control it, but it checks the DB and returns the status properly. Fixes: 7cdffe7
Configuration menu - View commit details
-
Copy full SHA for ad95762 - Browse repository at this point
Copy the full SHA ad95762View commit details -
don't fail when the cli didn't return a correct task list
this can e.g. happen when the CLI is badly set up
Configuration menu - View commit details
-
Copy full SHA for 2b17262 - Browse repository at this point
Copy the full SHA 2b17262View commit details -
Configuration menu - View commit details
-
Copy full SHA for 443e77b - Browse repository at this point
Copy the full SHA 443e77bView commit details