Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't fail when pulp cli didn't return valid json #956

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Nov 29, 2024

No description provided.

@evgeni
Copy link
Member Author

evgeni commented Nov 29, 2024

I'm still puzzled why 95e9d5a was not sufficient, aka: in which case pulp cli doesn't return valid JSON yet does not exit non-zero

(Waiting on feedback from the person who reported the issue)

@evgeni
Copy link
Member Author

evgeni commented Nov 29, 2024

#  pulp --format json task list --state-in running --state-in canceling
/usr/lib/python3.11/site-packages/urllib3/connection.py:463: SubjectAltNameWarning: Certificate for foreman.example.com has no `subjectAltName`, falling back to check for a `commonName` for now. This feature is being removed by major browsers and deprecated by RFC 2818. (See https://github.com/urllib3/urllib3/issues/497 for details.)
  warnings.warn(
[]

the warning is on stderr, so we mix those two up somewhere.

@evgeni
Copy link
Member Author

evgeni commented Nov 29, 2024

whyyyyyyyyyyyy

@ehelms ehelms merged commit 98abc02 into master Dec 2, 2024
7 of 8 checks passed
@ehelms ehelms deleted the damn-jason branch December 2, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants