do not load non-existant charts.js #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👀 @laugmanuel @kamils-iRonin ;-) |
|
Can you retrigger Github Actions? I'm not that familiar with the plugin. Can you jump in @kamils-iRonin ? |
|
for some reason I cannot, but I can force push? |
evgeni
force-pushed
the
top-of-the-patches
branch
from
037ded3
to
74d3711
Compare
|
doesn't look any happier 🤷♀️ |
|
I opened a new PR (#65) to fix the pipeline, I don't think rubocop failure is related to this one |
We used charts.js from Foreman, but that was dropped in Foreman 3.0 (theforeman/foreman@69379b5) and results in 404 errors when trying to load some pages Fixes: 28d49d8
evgeni
force-pushed
the
top-of-the-patches
branch
from
74d3711
to
f1338ca
Compare
|
all 🍏 |
kamils-iRonin
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used charts.js from Foreman, but that was dropped in Foreman 3.0 (theforeman/foreman@69379b5) and results in 404 errors when trying to load some pages
Fixes: 28d49d8