-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make changelog generation more robust and resilient #564
Conversation
This is still not working properly. I fixed the issue of the incorrect version headings, but I'm still getting multiple problems:
Here is my
Having identified and fixed the issue that was causing incorrect version headings, I'm going to revert some of my other changes and see how it behaves. |
2ab44bb
to
ad6f7a2
Compare
ad6f7a2
to
de713cf
Compare
I'm still getting the issue of 4.9.2 changelogs populated with duplicate 4.9.1 and 4.9.0 changes and no actual 4.9.2 changes:
|
I think the issue was with the instructions not including the |
Closing this, I'll fix the generated instructions.
|
I think something is still not correct with changelog generation. Comparing the changelogs at Katello/katello#10726 vs. the cherry-picked commits, only 20% of the cherry-picked commits got a corresponding changelog entry. If I can identify what is causing the discrepancy, I'll open a new PR to resolve it. |
The changelogs I'm getting with katello don't make much sense really. This is a WIP attempt at making the script respect the existing changelog rather than completely rewriting it with (I've observed) different results