Make instances deinit when player leaves (#1889)

* make instances deinit when player leaves

* Revert

* Fix

* Fix

* Fix

lua/starfall/editor/sfframe.lua

@@ -2079,7 +2079,7 @@ function PANEL:UpdatePlayers(players)
 
 			local svtotal = 0
 			local cltotal = 0
-			for instance, _ in pairs(SF.playerInstances[ply]) do
+			for instance, _ in pairs(rawget(SF.playerInstances, ply) or {}) do
 				svtotal = svtotal + (instance.entity:IsValid() and instance.entity:GetNWInt("CPUus") or 0)
 				cltotal = cltotal + instance.cpu_average
 			end

lua/starfall/instance.lua

@@ -30,7 +30,12 @@ SF.Instance.__index = SF.Instance
 --- A set of all instances that have been created. It has weak keys and values.
 -- Instances are put here after initialization.
 SF.allInstances = {}
-SF.playerInstances = setmetatable({}, {__index = function() return {} end})
+SF.playerInstances = SF.EntityTable("playerInstances", function(ply, instances)
+	for instance in pairs(instances) do
+		instance:Error({message = "Player disconnected!", traceback = ""})
+	end
+end)
+getmetatable(SF.playerInstances).__index = function(t,k) local r={} t[k]=r return r end
 
 local plyPrecacheTimeBurst = SF.BurstObject("model_precache_time", "Model precache time", 5, 0.2, "The rate allowed model precache time regenerates.", "Amount of allowed model precache time.")
 
@@ -608,11 +613,7 @@ function SF.Instance:initialize()
 	self.cpu_softquota = 1
 
 	SF.allInstances[self] = true
-	if rawget(SF.playerInstances, self.player) then
-		SF.playerInstances[self.player][self] = true
-	else
-		SF.playerInstances[self.player] = {[self] = true}
-	end
+	SF.playerInstances[self.player][self] = true
 
 	self:RunHook("initialize")