Catch ASN Parse error more gracefully #626
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently saw a bunch of exceptions when looking up an ASN from IP addresses.
This handles them more gracefully while we investigate what's causing them.
This pull request includes changes to the
apps/greencheck
module to improve error handling and testing. The most important changes involve adding a new exception type to the imports, updating error handling in thecheck_for_matching_asn
method, and adding a new test case to ensure the new error handling works as expected.Improvements to error handling:
apps/greencheck/domain_check.py
: AddedASNParseError
to the list of imported exceptions.apps/greencheck/domain_check.py
: Updated thecheck_for_matching_asn
method to handleASNParseError
and log a warning message when this exception occurs.Enhancements to testing:
apps/greencheck/tests/test_domain_checker.py
: Added a new test casetest_asn_from_ip_fails_gracefully_with_bad_asn_lookup
to verify thatASNParseError
is caught and logged correctly.