-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up OneByte tests #151
Clean up OneByte tests #151
Conversation
These may already be tested in |
@EvanHahn thanks for this. It would actually be nice to reduce the number of tests in the Using toBeCloseTo() looks good, and will definitely make our test cases more flexible as grid intensity data changes. Do you want to use the PR to add more tests to the |
This test-only change: - Tests various permutations of `perByte()` - Uses [`toBeCloseTo()`][0] (see [issue thegreenwebfoundation#98][1]) [0]: https://jestjs.io/docs/expect#tobeclosetonumber-numdigits [1]: thegreenwebfoundation#98
This also cleans up the exports from `test-constants.js`.
d9bea96
to
0e6b481
Compare
I removed two redundant tests from
It looks like the Again, feel free to message me on the CAT Slack or email [email protected]. |
@EvanHahn thank you for this, looks good to me. |
This test-only change:
perByte()
toBeCloseTo()
(see Improve the robustness of the test suite #98)