-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infra/fairspc 23 GitHub actions ci #1455
Conversation
echo "Building images of version: $VER" | ||
|
||
# GET DATE AND TIME FOR VERSIONING | ||
DATE=$(date "+%Y%m%d%H%M%S") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
although it is nice and specific, I wonder if we need the date timestamp, it will lead to many different package files. I would just create a 'latest' stamp, which is always the latest build. Introduce the timestamps at a point where we really need this.
Also I would like distinction between dev and release builds. Everything from the release branch should be ready to ship to production, this is not what I expect from a dev image. Let's discuss in the office today how to manage this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good points, let's discuss it in the office
I will play a bit with the latest tag in the meantime
TBD: release strategy + tagging |
cc2c960
to
a79f7c2
Compare
Agreed with @ewelinagr and @frankyhollywood :
|
…e security switched off on cache refresh (#1471)
4c0266a
to
2e90fc9
Compare
NOTE: agreed with Frank that first we need to discuss all together the release strategy and tagging strategy before accepting the approach from the pull request. I will schedule a call on the beginning of January
PS: all commits will be shrinked into one with proper message on merge