Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infra/fairspc 23 GitHub actions ci #1455

Merged
merged 68 commits into from
Jan 25, 2024
Merged

Conversation

tgreenwood
Copy link
Contributor

@tgreenwood tgreenwood commented Dec 19, 2023

NOTE: agreed with Frank that first we need to discuss all together the release strategy and tagging strategy before accepting the approach from the pull request. I will schedule a call on the beginning of January

  1. Two new Github Actions CI workflows were introduced. One is for build services on pull request related events (all jobs for services are run in parallel). Another one is for pushes to 'dev' branch (flow described in the 'build_and_upload_on_push_to_dev.yaml' file)
  2. TravisCI related files are still present: new tickets to be created to introduce workflows for documentation, releases, tags, etc.
  3. Now versions (images' tags) are equal for all images per build and unique (date-time is appended)

PS: all commits will be shrinked into one with proper message on merge

@tgreenwood tgreenwood added the improvement Includes improvements that are not crucial label Dec 19, 2023
@tgreenwood tgreenwood self-assigned this Dec 19, 2023
echo "Building images of version: $VER"

# GET DATE AND TIME FOR VERSIONING
DATE=$(date "+%Y%m%d%H%M%S")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

although it is nice and specific, I wonder if we need the date timestamp, it will lead to many different package files. I would just create a 'latest' stamp, which is always the latest build. Introduce the timestamps at a point where we really need this.

Also I would like distinction between dev and release builds. Everything from the release branch should be ready to ship to production, this is not what I expect from a dev image. Let's discuss in the office today how to manage this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good points, let's discuss it in the office

I will play a bit with the latest tag in the meantime

@tgreenwood tgreenwood marked this pull request as draft December 22, 2023 19:26
@tgreenwood
Copy link
Contributor Author

TBD: release strategy + tagging

@tgreenwood tgreenwood force-pushed the infra/FAIRSPC-23_github_actions_CI branch from cc2c960 to a79f7c2 Compare January 4, 2024 15:36
@tgreenwood
Copy link
Contributor Author

Agreed with @ewelinagr and @frankyhollywood :

  • to hold only the latest version of snapshots (no timestamps needed)
  • add the release flow triggered on a merge to the release branch: (RELEASE-[version])
  • commit a minor version increment change once release has been created
  • create ticket for helm charts

@tgreenwood tgreenwood force-pushed the infra/FAIRSPC-23_github_actions_CI branch from 4c0266a to 2e90fc9 Compare January 25, 2024 11:09
@tgreenwood tgreenwood marked this pull request as ready for review January 25, 2024 11:11
@tgreenwood tgreenwood merged commit eeaf8f5 into dev Jan 25, 2024
5 checks passed
@tgreenwood tgreenwood deleted the infra/FAIRSPC-23_github_actions_CI branch March 4, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Includes improvements that are not crucial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants