Correction for old merge #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge changes from main
reverse pull request - sync forked repository with original
merge from original hadge, deleting demuxmix from forked
Reverse Pull Request - adding 3 changes from original
Zethson
reviewed
Jan 8, 2024
bin/summary_hash.py
Outdated
| @@ -105,7 +104,8 @@ def hashsolo_summary(hashsolo_res, raw_adata, raw_mudata): | |||
| mudata.write("hash_summary/mudata/mudata_with_mudata_"+ os.path.basename(x)+".h5mu") | |||
|
|
|||
| hashsolo_classi = obs_res[["most_likely_hypothesis"]] | |||
| hashsolo_classi.loc[:, "most_likely_hypothesis"] = hashsolo_classi["most_likely_hypothesis"].replace({0.0: "negative", 1.0: "singlet", 2.0: "doublet"}) | |||
| #hashsolo_classi.loc[:, "most_likely_hypothesis"] = hashsolo_classi["most_likely_hypothesis"].replace({0.0: "negative", 1.0: "singlet", 2.0: "doublet"}) | |||
There was a problem hiding this comment.
I added a different way to do the same as in the commented line, because it was producing a warning from pandas.
Commeted line is now out
bin/summary_hash.py
Outdated
| classification_dt["classification"] = classification_dt["assignment"].apply(lambda x: "doublet" if x else "singlet") | ||
| classification_dt.at[0, "classification"] = "negative" | ||
|
|
||
| ##Inner function |
There was a problem hiding this comment.
Suggested change
| ##Inner function |
bin/summary_hash.py
Outdated
| classification_dt.at[0, "classification"] = "negative" | ||
|
|
||
| ##Inner function | ||
| def classify_hash(row,number_hashes): |
There was a problem hiding this comment.
Inner functions should be prefixed with _
comments from PR resolved, file multi_sample_input.csv now in test_data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on multiple data completed