Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some modifications made to Hadge that were esential for running large scale processing of Onek1k data #37

Merged
merged 17 commits into from
Feb 8, 2024

Conversation

maxozo
Copy link
Collaborator

@maxozo maxozo commented Feb 2, 2024

This pull request addresses couple of things:

  1. I have added a snippet from nf-core so that i can provide a profile for different institutes. Can run it as in: -profile sanger,cluster,singularity,test
  2. There was a lot of redundant modules created by multi and single mode (please let me know if you do not agree with this strategy - but i double checked both single and multi and the modules are the same with only a slight modification). I think its better for a long term maintenance of the pipeline to rely on just one branch, so so same vireo module is used both in single and multi mode. this cleans up the pipeline significantly.
  3. I have changed to outputdirectory paths. Output paths shouldnt contain $projectDir - this causes issues providing full paths and places results wherever hadge is cloned.
  4. freebayes takes ages to run. for this reason i added an optional subsetting module that preprocesses bam and removes the variants that we would not use in deconvolutions anyways. for OneK1k i subset the bams down to cellsnp comon variants to speed up the pipeline.
  5. there was a conflicts with the output directories in genetics summary module. the logic of input chanels in this module had to be changed.

Copy link
Member

@Zethson Zethson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

bin/bff.R Show resolved Hide resolved
modules/multi/gene_demultiplexing.nf Outdated Show resolved Hide resolved
modules/multi/hash_demulti/demuxem.nf Outdated Show resolved Hide resolved
subworkflows/HADGE.nf Outdated Show resolved Hide resolved
@Zethson Zethson requested a review from wxicu February 2, 2024 13:40
Matiss Ozols and others added 10 commits February 7, 2024 09:22
Copy link
Collaborator

@wxicu wxicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!! I adaped the code to the hashing workflow. Everything looks good now.

@wxicu wxicu merged commit a9286cb into theislab:main Feb 8, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants