Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add draft of perturbation notebook #59

Merged
merged 4 commits into from
Feb 13, 2024

Conversation

MUCDK
Copy link
Collaborator

@MUCDK MUCDK commented Nov 30, 2023

No description provided.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

review-notebook-app bot commented Jan 26, 2024

View / edit / reply to this conversation on ReviewNB

MUCDK commented on 2024-01-26T07:51:45Z
----------------------------------------------------------------

It's Filter the data


Copy link

review-notebook-app bot commented Jan 26, 2024

View / edit / reply to this conversation on ReviewNB

MUCDK commented on 2024-01-26T07:51:46Z
----------------------------------------------------------------

Can you please motivate why you are using the StarPolicy? (it's correct, but please justify)

Also, the problem order here is weird, it should be the other way round. Let's keep it for now, but please open an issue on moscot main repo.


Copy link

review-notebook-app bot commented Jan 26, 2024

View / edit / reply to this conversation on ReviewNB

MUCDK commented on 2024-01-26T07:51:47Z
----------------------------------------------------------------

I know this is from my original suggestions, but can we please rename "key_added", not my_pull,but maybe just pull or so?


Copy link

review-notebook-app bot commented Jan 26, 2024

View / edit / reply to this conversation on ReviewNB

MUCDK commented on 2024-01-26T07:51:48Z
----------------------------------------------------------------

can you please use moscot.plotting.pull for this?


@MUCDK MUCDK merged commit 73c4ecf into main Feb 13, 2024
1 check passed
@MUCDK MUCDK deleted the notebook/perturbation_with_sinkhorn_solver branch February 13, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants