Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve mapping tutorial #86

Merged
merged 2 commits into from
Dec 16, 2024
Merged

improve mapping tutorial #86

merged 2 commits into from
Dec 16, 2024

Conversation

ArinaDanilina
Copy link
Collaborator

No description provided.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ArinaDanilina ArinaDanilina requested a review from MUCDK December 3, 2024 17:12
Copy link

review-notebook-app bot commented Dec 5, 2024

View / edit / reply to this conversation on ReviewNB

MUCDK commented on 2024-12-05T07:37:18Z
----------------------------------------------------------------

add a link to the alignment problem, and briefly state in one sentence what the alignment does (in contrast to the mapping)


Copy link

review-notebook-app bot commented Dec 5, 2024

View / edit / reply to this conversation on ReviewNB

MUCDK commented on 2024-12-05T07:37:19Z
----------------------------------------------------------------

"it can be useful to increase the alpha value". add what that means, i.e. more weight to spatial term


Copy link
Collaborator

@MUCDK MUCDK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm

@ArinaDanilina ArinaDanilina merged commit 618f3ce into main Dec 16, 2024
1 check passed
@ArinaDanilina ArinaDanilina deleted the improve/mapping_tutorial branch December 16, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants