Draft PR for review comments of infraclouds contributions #2
Conversation
…oudio/cassandra into infracloud/cassandra-5.0
| kubectl cp -n $KUBE_NS $POD_NAME:$BUILD_DIR/$build_number/log $LOCAL_DIR/$build_number/log | ||
| kubectl cp -n $KUBE_NS $POD_NAME:$BUILD_DIR/$build_number/junitResult.xml $LOCAL_DIR/$build_number/junitResult.xml | ||
|
|
||
|
|
There was a problem hiding this comment.
we're missing here the teardown of the jenkins stack.
and this needs to be optional via a parameter.
something along the lines of
# teardown # TODO add option to skip this
kubectl delete --namespace ${KUBE_NS} -f ${CASSANDRA_DIR}/build/jenkins-deployment.yaml
kubectl delete "$(kubectl api-resources --namespaced=true --verbs=delete -o name | tr "\n" "," | sed -e 's/,$//')" --all
[ "default" == "${KUBE_NS}" ] || kubectl delete namespace ${KUBE_NS}
There was a problem hiding this comment.
you can leave this, i will tackle it.
There was a problem hiding this comment.
Since for now, the jenkins deployment is working with default namespace only (the limitation we mentioned earlier), so there is no need to delete the default namespace, we can remove the delete command (for namespace)
There was a problem hiding this comment.
We have added the teardown code, also parameterised it as well
.build/run-ci.sh
Outdated
| sed -i -e "/targets:/s|:.*$|: \"$TARGETS\"|" \ | ||
| -e "/repositoryBranch:/s|:.*$|: \"$REPO_BRANCH\"|" \ | ||
| -e "/repositoryUrl:/s|:.*$|: \"$REPO_URL\"|" jenkins-deployment.yaml | ||
|
|
There was a problem hiding this comment.
fix needed for macos compatibility
| sed -i -e "/targets:/s|:.*$|: \"$TARGETS\"|" \ | |
| -e "/repositoryBranch:/s|:.*$|: \"$REPO_BRANCH\"|" \ | |
| -e "/repositoryUrl:/s|:.*$|: \"$REPO_URL\"|" jenkins-deployment.yaml | |
| sed -e "/targets:/s|:.*$|: \"$TARGETS\"|" \ | |
| -e "/repositoryBranch:/s|:.*$|: \"$REPO_BRANCH\"|" \ | |
| -e "/repositoryUrl:/s|:.*$|: \"$REPO_URL\"|" ${CASSANDRA_DIR}/.build/jenkins-deployment.yaml > ${CASSANDRA_DIR}/build/jenkins-deployment.yaml | |
.build/run-ci.sh
Outdated
| echo "Jenkins Operator installed successfully!" # condition to check if above command was success | ||
|
|
||
| # deploy jenkins Instance TODO jenkins file parameter | ||
| kubectl apply --namespace ${KUBE_NS} -f ${CASSANDRA_DIR}/.build/jenkins-deployment.yaml |
There was a problem hiding this comment.
to go with the fix above
| kubectl apply --namespace ${KUBE_NS} -f ${CASSANDRA_DIR}/.build/jenkins-deployment.yaml | |
| kubectl apply --namespace ${KUBE_NS} -f ${CASSANDRA_DIR}/build/jenkins-deployment.yaml |
.jenkins/pipelinecopy.jenkins
Outdated
There was a problem hiding this comment.
can we delete this file now ?
There was a problem hiding this comment.
This file has a code block (artifacts stage), which will require modifications of the existing bash scripts but it will help with getting rid of DinD. So, keeping this file for reference purposes. Also renaming it to k8s_POC.jenkins
…oudio/cassandra into infracloud/cassandra-5.0
Co-authored-by: mck <[email protected]>
No description provided.