Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting and tweaks #477

Draft
wants to merge 19 commits into
base: master
Choose a base branch
from
Draft

Formatting and tweaks #477

wants to merge 19 commits into from

Conversation

buckyroberts
Copy link

No description provided.

@buckyroberts buckyroberts marked this pull request as draft October 29, 2021 03:07
@buckyroberts
Copy link
Author

Still having file issues:

File "/thenewboston_node/business_logic/blockchain/file_blockchain/__init__.py", 
line 52, in __init__
    raise ValueError('base_directory must be an absolute path')

pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@dmugtasimov
Copy link
Contributor

@buckyroberts I prefer to stick to one commit per PR with few exceptions. This makes commit history more readable and easier to rebase on. Multiple commits can be squashed before making PR or you can just use git commit --amend when add more changes to the existing commit.

abs_path = (base_path / path).resolve()
abs_path = (base_path / path).absolute()

if '..' in str(path):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a dirty hack. I would rather use os.path if pathlib is buggy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants