-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Formatting and tweaks #477
base: master
Are you sure you want to change the base?
Conversation
Still having file issues:
|
@buckyroberts I prefer to stick to one commit per PR with few exceptions. This makes commit history more readable and easier to rebase on. Multiple commits can be squashed before making PR or you can just use |
abs_path = (base_path / path).resolve() | ||
abs_path = (base_path / path).absolute() | ||
|
||
if '..' in str(path): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like a dirty hack. I would rather use os.path
if pathlib
is buggy
No description provided.