Add option to disable open port check

Closes #912
theotherp · Jan 10, 2024 · 658f755 · 658f755
1 parent bd08bda
commit 658f755
Show file tree

Hide file tree

Showing 6 changed files with 28 additions and 1 deletion.
diff --git a/core/src/main/java/org/nzbhydra/problemdetection/OpenPortProblemDetector.java b/core/src/main/java/org/nzbhydra/problemdetection/OpenPortProblemDetector.java
@@ -48,6 +48,10 @@ public class OpenPortProblemDetector implements ProblemDetector {
     public void executeCheck() {
         try {
             final AuthType authType = configProvider.getBaseConfig().getAuth().getAuthType();
+            if (!configProvider.getBaseConfig().getMain().isCheckOpenPort()) {
+                logger.debug("Not checking for open port because check is disabled");
+                return;
+            }
             if (authType != AuthType.NONE) {
                 logger.debug("Not checking for open port because auth method is {}", authType);
                 return;

diff --git a/core/src/main/resources/changelog.yaml b/core/src/main/resources/changelog.yaml
@@ -1,6 +1,8 @@
 #@formatter:off
 -   version: "v5.3.7"
     changes:
+      -   type: "feature"
+          text: "Add option to disable open port check. See #912"
       -   type: "fix"
           text: "Fix filtering of history by time. See #913"
     final: true

diff --git a/core/src/main/resources/static/js/nzbhydra.js b/core/src/main/resources/static/js/nzbhydra.js
@@ -6692,6 +6692,16 @@ function ConfigFields($injector) {
                                 advanced: true
                             }
                         },
+                        {
+                            key: 'checkOpenPort',
+                            type: 'horizontalSwitch',
+                            templateOptions: {
+                                type: 'switch',
+                                label: 'Check for open port',
+                                help: "Check if NZBHydra is reachable from the internet and not protected",
+                                advanced: true
+                            }
+                        },
                         {
                             key: 'xmx',
                             type: 'horizontalInput',

diff --git a/core/src/main/resources/static/js/nzbhydra.js.map b/core/src/main/resources/static/js/nzbhydra.js.map
diff --git a/core/ui-src/js/config/config-fields-service.js b/core/ui-src/js/config/config-fields-service.js
@@ -667,6 +667,16 @@ function ConfigFields($injector) {
                                 advanced: true
                             }
                         },
+                        {
+                            key: 'checkOpenPort',
+                            type: 'horizontalSwitch',
+                            templateOptions: {
+                                type: 'switch',
+                                label: 'Check for open port',
+                                help: "Check if NZBHydra is reachable from the internet and not protected",
+                                advanced: true
+                            }
+                        },
                         {
                             key: 'xmx',
                             type: 'horizontalInput',

diff --git a/shared/mapping/src/main/java/org/nzbhydra/config/MainConfig.java b/shared/mapping/src/main/java/org/nzbhydra/config/MainConfig.java
@@ -105,6 +105,7 @@ public class MainConfig {
     //Startup / GUI settings
     private boolean showNews = true;
     private boolean startupBrowser = true;
+    private boolean checkOpenPort = true;
     private boolean welcomeShown = false;
     protected String theme;